Skip to content

remove border from tree indent #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davegarthsimpson merged 2 commits into from
Jul 4, 2022
Merged

remove border from tree indent #1140

davegarthsimpson merged 2 commits into from
Jul 4, 2022

Conversation

@davegarthsimpson
Copy link
Collaborator

@davegarthsimpson davegarthsimpson commented Jul 4, 2022

Motivation

UI improvements.

Change description

simple css override.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos
Copy link
Contributor

kittaakos commented Jul 4, 2022

It's a brute-force fix. It might work, but there is a better way than using !important. Please take the time to investigate how this works and where it's coming from Theia.

Please add the "workbench.tree.renderIndentGuides": "none" to the preferences. Let me know if you have any questions.

@davegarthsimpson
Copy link
Collaborator Author

davegarthsimpson commented Jul 4, 2022

It's a brute-force fix. It might work, but there is a better way than using !important. Please take the time to investigate how this works and where it's coming from Theia.

Please add the "workbench.tree.renderIndentGuides": "none" to the preferences. Let me know if you have any questions.

Of course !important is always a last resort. Given the issue had been open a while I made the assumption it wasn't as simple as a config change, and override was necessary.

I'll make the required change.

@davegarthsimpson davegarthsimpson removed the request for review from francescospissu July 4, 2022 09:33
francescospissu
francescospissu approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@francescospissu francescospissu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 4, 2022
@davegarthsimpson davegarthsimpson merged commit 5da558d into main Jul 4, 2022
@davegarthsimpson davegarthsimpson deleted the hide-line-in-tree-indent branch July 4, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francescospissu francescospissu francescospissu approved these changes

+1 more reviewer

@kittaakos kittaakos kittaakos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic: code Related to content of the project itself type: enhancement Proposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davegarthsimpson @kittaakos @francescospissu @per1234