put Arduino boards on top

Author: francescospissu

arduino-ide-extension/src/browser/library/library-list-widget.ts

@@ -189,35 +189,6 @@ export class LibraryListWidget extends ListWidget<
       { timeout: 3000 }
     );
   }
-
-  protected override filterableListSort = (
-    items: LibraryPackage[]
-  ): LibraryPackage[] => {
-    const isArduinoTypeComparator = (
-      left: LibraryPackage,
-      right: LibraryPackage
-    ) => {
-      const aIsArduinoType = left.types.includes('Arduino');
-      const bIsArduinoType = right.types.includes('Arduino');
-
-      if (aIsArduinoType && !bIsArduinoType) {
-        return -1;
-      }
-
-      if (!aIsArduinoType && bIsArduinoType) {
-        return 1;
-      }
-
-      return 0;
-    };
-
-    return items.sort((left, right) => {
-      return (
-        isArduinoTypeComparator(left, right) ||
-        this.defaultSortComparator(left, right)
-      );
-    });
-  };
 }
 
 class MessageBoxDialog extends AbstractDialog<MessageBoxDialog.Result> {

arduino-ide-extension/src/browser/widgets/component-list/list-widget.tsx

@@ -142,7 +142,27 @@ export abstract class ListWidget<
   }
 
   protected filterableListSort = (items: T[]): T[] => {
-    return items.sort(this.defaultSortComparator);
+    const isArduinoTypeComparator = (left: T, right: T) => {
+      const aIsArduinoType = left.types.includes('Arduino');
+      const bIsArduinoType = right.types.includes('Arduino');
+
+      if (aIsArduinoType && !bIsArduinoType) {
+        return -1;
+      }
+
+      if (!aIsArduinoType && bIsArduinoType) {
+        return 1;
+      }
+
+      return 0;
+    };
+
+    return items.sort((left, right) => {
+      return (
+        isArduinoTypeComparator(left, right) ||
+        this.defaultSortComparator(left, right)
+      );
+    });
   };
 
   render(): React.ReactNode {