moves over Arduino libs based on types field

Author: francescospissu

arduino-ide-extension/src/browser/library/library-list-widget.ts

@@ -190,18 +190,21 @@ export class LibraryListWidget extends ListWidget<
     );
   }
 
-  protected override filterableListSort(
+  protected override filterableListSort = (
     items: LibraryPackage[]
-  ): LibraryPackage[] {
-    const isArduinoMaintainedComparator = (
+  ): LibraryPackage[] => {
+    const isArduinoTypeComparator = (
       left: LibraryPackage,
       right: LibraryPackage
     ) => {
-      if (left.isArduinoMaintained && !right.isArduinoMaintained) {
+      const aIsArduinoType = left.types.includes('Arduino');
+      const bIsArduinoType = right.types.includes('Arduino');
+
+      if (aIsArduinoType && !bIsArduinoType) {
         return -1;
       }
 
-      if (!left.isArduinoMaintained && right.isArduinoMaintained) {
+      if (!aIsArduinoType && bIsArduinoType) {
         return 1;
       }
 
@@ -210,11 +213,11 @@ export class LibraryListWidget extends ListWidget<
 
     return items.sort((left, right) => {
       return (
-        isArduinoMaintainedComparator(left, right) ||
+        isArduinoTypeComparator(left, right) ||
         this.defaultSortComparator(left, right)
       );
     });
-  }
+  };
 }
 
 class MessageBoxDialog extends AbstractDialog<MessageBoxDialog.Result> {

arduino-ide-extension/src/browser/widgets/component-list/list-widget.tsx

@@ -74,14 +74,14 @@ export abstract class ListWidget<
 
       return itemLabel(left).localeCompare(itemLabel(right));
     };
-
-    this.filterableListSort = this.filterableListSort.bind(this);
   }
 
   @postConstruct()
   protected init(): void {
     this.toDispose.pushAll([
-      this.notificationCenter.onIndexUpdateDidComplete(() => this.refresh(undefined)),
+      this.notificationCenter.onIndexUpdateDidComplete(() =>
+        this.refresh(undefined)
+      ),
       this.notificationCenter.onDaemonDidStart(() => this.refresh(undefined)),
       this.notificationCenter.onDaemonDidStop(() => this.refresh(undefined)),
     ]);
@@ -141,9 +141,9 @@ export abstract class ListWidget<
     return this.options.installable.uninstall({ item, progressId });
   }
 
-  protected filterableListSort(items: T[]): T[] {
+  protected filterableListSort = (items: T[]): T[] => {
     return items.sort(this.defaultSortComparator);
-  }
+  };
 
   render(): React.ReactNode {
     return (

arduino-ide-extension/src/common/protocol/arduino-component.ts

@@ -10,7 +10,6 @@ export interface ArduinoComponent {
   readonly availableVersions: Installable.Version[];
   readonly installable: boolean;
   readonly installedVersion?: Installable.Version;
-  readonly isArduinoMaintained?: boolean;
   /**
    * This is the `Type` in IDE (1.x) UI.
    */

arduino-ide-extension/src/node/library-service-impl.ts

@@ -456,6 +456,5 @@ function toLibrary(
     summary: lib.getParagraph(),
     category: lib.getCategory(),
     types: lib.getTypesList(),
-    isArduinoMaintained: lib.getAuthor() === 'Arduino', // TODO check if .getMaintainer is more appropriate
   };
 }