Refactor template format #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polldo
added a commit
that referenced
this pull request
Sep 2, 2022
Thing templates are now supported in both json and yaml formats. This means that, during the thing creation, the thing template can be passed either as json or yaml file. On the other hand, during the template extraction, the user can specify his preferred format with an appropriate flag. The default value for the format is yaml. $ ./iot-cloud-cli thing extract --format json * Thing template - Support both yaml and json formats * Update docs * Extract template supports multiple formats * thing extract - set yaml as default format * Update readme
polldo
added a commit
that referenced
this pull request
Sep 2, 2022
Thing templates are now supported in both json and yaml formats. This means that, during the thing creation, the thing template can be passed either as json or yaml file. On the other hand, during the template extraction, the user can specify his preferred format with an appropriate flag. The default value for the format is yaml. $ ./iot-cloud-cli thing extract --format json * Thing template - Support both yaml and json formats * Update docs * Extract template supports multiple formats * thing extract - set yaml as default format * Update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Thing templates are now supported in both json and yaml formats.
This means that, during the thing creation, the thing template can be passed either as json or yaml file.
On the other hand, during the template extraction, the user can specify his preferred format with an appropriate flag. The default value for the format is
yaml.$ ./iot-cloud-cli thing extract --format jsonChange description
Additional Notes
Reviewer checklist
main.CONTRIBUTING.md) and are well formatted.