Add thing create command #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameters to create a new thing are: - thing name - mandatory - device (id) to bind the thing to - optional - thing template - mandatory if no thing to clone is passed - thing to clone (id) - mandatory if no template note that: - iot client is really ugly and should be refactored -> the problem is that iot-client-go doesn't accept the 'properties' field when creating a new thing. For this reason a standard http request has been performed. todos and questions: - improve naming of create flags and create params (maybe it's not clear that IDs should be used) - is template or thing to be cloned a real requirement? An empty thing could also make sense - refactor iot client AddThing -> prerequisite: add the properties parameter in iot-client-go - thing Create function stores the thing parameters into an empty interface -> this will be replaced into a proper structure as soon as iot-client-go can handle properties
Given that iot-client-go has been updated and now supports the creation of things with a slice of properties, it's been here employed to create a thing. Issue: response's error details, coming from arduino iot cloud, are masked by iot-client-go
2137817 to
05f124a
Compare
27f570e to
10723b7
Compare
10723b7 to
4e7348c
Compare
polldo
added a commit
that referenced
this pull request
Sep 2, 2022
things can be created in two ways:
- starting from a template. templates can be extracted from existing things
- cloning another thing, already available on arduino iot cloud
The parameters to create a new thing are:
- thing name - mandatory
- device (id) to bind the thing to - optional
- thing template - mandatory if no thing to clone is passed
- thing to clone (id) - mandatory if no template
commits history:
* Add thing create command
* Check clone params before copying
* Thing create uses updated iot-client-go
Given that iot-client-go has been updated and now supports the creation of things with a slice of properties, it's been here employed to create a thing.
Issue: response's error details, coming from arduino iot cloud, are masked by iot-client-go
* Add optional
* fix thing create - improve flags
* Update readme
polldo
added a commit
that referenced
this pull request
Sep 2, 2022
things can be created in two ways:
- starting from a template. templates can be extracted from existing things
- cloning another thing, already available on arduino iot cloud
The parameters to create a new thing are:
- thing name - mandatory
- device (id) to bind the thing to - optional
- thing template - mandatory if no thing to clone is passed
- thing to clone (id) - mandatory if no template
commits history:
* Add thing create command
* Check clone params before copying
* Thing create uses updated iot-client-go
Given that iot-client-go has been updated and now supports the creation of things with a slice of properties, it's been here employed to create a thing.
Issue: response's error details, coming from arduino iot cloud, are masked by iot-client-go
* Add optional
* fix thing create - improve flags
* Update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
iot-cloud-cli should provide a command to create things on arduino iot cloud.
things could be created by:
Change description
the parameters to create a new thing are:
Additional Notes
note that:
iot client has been refactored
Reviewer checklist
main.CONTRIBUTING.md) and are well formatted.