Skip to content

Conversation

@polldo
Copy link
Contributor

@polldo polldo commented Aug 17, 2022

Motivation

There is a nasty leftover: I changed the name of credentials IsEmpty method without changing its logic.
Also, we actually need to know if the credentials config file has any mandatory parameter or not. Thus, the name IsEmpty fits better this need.

Change description

Put back the old IsEmpty name.

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo requested a review from rsora August 17, 2022 10:21
Copy link

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@polldo polldo merged commit 39b25aa into main Aug 17, 2022
@polldo polldo deleted the polldo/cred-isempty branch August 17, 2022 10:29
polldo added a commit that referenced this pull request Sep 2, 2022
polldo added a commit that referenced this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants