Skip to content

Conversation

@polldo
Copy link
Contributor

@polldo polldo commented Aug 4, 2022

Motivation

The ota upload command was not working due to a api change on iot-api.
We need to update the iot-client-go and satisfy the new api by adding the new async parameter.

Change description

  • update iot-client-go dependency
  • fill the new async parameter assigning always true, in order to be consistent with previous behavior

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo requested a review from rsora August 4, 2022 07:27
Copy link

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@polldo polldo merged commit f168c39 into main Aug 9, 2022
@polldo polldo deleted the polldo/fix-ota branch August 9, 2022 13:42
polldo added a commit that referenced this pull request Sep 2, 2022
polldo added a commit that referenced this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants