Improve interrupt handling response time #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the way ISRs are stored. Store now in a list on a ‘first come first served basis’, the first interrupt that gets attached will be served first. This improves the speed of the ISR calling from about 6us to 2us for a single interrupt on extint14 See arduino#200
This should save some cycles inside ISR Handler.
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
Contributor
|
Hi Christian,
Its been a while since I looked athe code, but I implemented the NULL callback possibility to allow setting up the interrupt register and assigning e.g fallng edge and convenient interrupt number with the attachinterrupt routine while not connecting an ISR to it. Then you can set up some low level hardware interupt connected to this interrupt like for creating a pwm signal, but now enjoying the fast response of hardware connected interrupt without needing the isr.
This is not essential as anyone fiddling with the low level registers should be able to find out how to set up the interrupt, but in my experience it takes a while before everything reacts as you thought it would and having at least piece of the setup that you can trust was nice for me.
Regards and thanks a lot for the improvements.
(I bet I should answer this email somewhere in the forum but I looked and it made me confused again) maybe i should read a beginners guide to contributing to open source.
Jo
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of @joverbee's patch #201
EIC_Handler@joverbee I see that you added a case to allow passing NULL as a callback:
9a49ce2#diff-2d6f462f44c0386e70bfb9e3ba804d5bR87
may you explain better what's the purpose of this?