-
Notifications
You must be signed in to change notification settings - Fork 5
Rename Location to CellularLocation #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Location to CellularLocation #12
Conversation
|
Memory usage change @ c651122
Click for full report table
Click for full report CSV |
sebromero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think CellularLocation is a bit misleading as this is a GPS location. @cristidragomir97 let's come up with something that is easier to grasp.
GeographicalLocation ? |
Yes, how about |
sebromero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied my suggestion
|
Memory usage change @ 51be44a
Click for full report table
Click for full report CSV |
Location struct clashes with https://github.com/arduino-libraries/ArduinoIoTCloud/blob/cd09f04a5b38c5ad1628e2604e6411c0c28977bd/src/property/types/CloudLocation.h#L35