Skip to content

Conversation

@OmarAli3
Copy link
Contributor

No description provided.

@per1234
Copy link
Contributor

per1234 commented Mar 18, 2020

Fixes #16

@MisterAwesome23
Copy link

I feel it can be improved minutely.

No need to use abs(), two reasons, technically sound can be negative decibels also, the amplitudeAnalyzer.read() should ideally return a non negative value so no need of abs()

@OmarAli3
Copy link
Contributor Author

Hi @MisterAwesome23, thanks for your comment.

  • Regarding first reason, taking abs() inside log() will not prevent negative values so decibels still can be negative.
  • Regarding second reason, I am not very sure but in practice amplitude can be negative so took into consideration.

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you @OmarAli3 🚀

@aentinger aentinger merged commit ce85b71 into arduino-libraries:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants