Skip to content

Service query is overflowing #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Luftzig wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −10
Open

Service query is overflowing #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions MDNS.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,8 @@ int MDNS::startDiscoveringService(const char* serviceName,
unsigned long timeout)
{
this->stopDiscoveringService();
char* n = (char*)my_malloc(strlen(serviceName) + 13);

char* n = (char*)my_malloc(strlen(serviceName));
if (NULL == n)
return 0;

Expand Down Expand Up @@ -323,9 +323,6 @@ MDNSError_t MDNS::_sendMDNSMessage(uint32_t /*peerAddress*/, uint32_t xid, int t
break;
}




this->_udp->beginPacket(mdnsMulticastIPAddr,MDNS_SERVER_PORT);
this->_udp->write((uint8_t*)dnsHeader,sizeof(DNSHeader_t));

Expand Down Expand Up @@ -456,9 +453,10 @@ MDNSError_t MDNS::_sendMDNSMessage(uint32_t /*peerAddress*/, uint32_t xid, int t
buf[1] = (type == MDNSPacketTypeServiceQuery) ? 0x0c : 0x01;
buf[3] = 0x1;

this->_udp->write((uint8_t*)buf, sizeof(DNSHeader_t));
ptr += sizeof(DNSHeader_t);

this->_udp->write((uint8_t*)buf, 4);
// ptr += sizeof(DNSHeader_t);
ptr += 4;

this->_resolveLastSendMillis[(type == MDNSPacketTypeServiceQuery) ? 1 : 0] = millis();

break;
Expand Down Expand Up @@ -1253,8 +1251,11 @@ void MDNS::removeAllServiceRecords()
this->_removeServiceRecord(i);
}

void MDNS::_writeDNSName(const uint8_t* name, uint16_t* pPtr,
uint8_t* buf, int bufSize, int zeroTerminate)
void MDNS::_writeDNSName(const uint8_t* name,
uint16_t* pPtr,
uint8_t* buf,
int bufSize,
int zeroTerminate)
{
uint16_t ptr = *pPtr;
uint8_t* p1 = (uint8_t*)name, *p2, *p3;
Expand Down