Skip to content

Conversation

@fischaz
Copy link
Contributor

@fischaz fischaz commented Dec 1, 2025

Description

Update the regular expression detecting a ECR image to include the dualstack pattern so ensure that AWS/ECR authentication continues to work on the new images.

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ fischaz
✅ DmitriyLewen
❌ Johan Fischer


Johan Fischer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@fischaz fischaz marked this pull request as draft December 1, 2025 05:10
@fischaz fischaz changed the title Add support for Dualstack ECR Endpoints feat(aws): Add support for Dualstack ECR Endpoints Dec 1, 2025
@fischaz
Copy link
Contributor Author

fischaz commented Dec 1, 2025

before

can be found in the comment #9861 (comment) which uses the main/latest official version

after

Local build:

➜  trivy git:(main) ✗ ./trivy version  
Version: cae72026
Vulnerability DB:
  Version: 2
  UpdatedAt: 2025-12-01 18:28:50.844697798 +0000 UTC
  NextUpdate: 2025-12-02 18:28:50.844697527 +0000 UTC
  DownloadedAt: 2025-12-01 21:48:57.872102 +0000 UTC
Java DB:
  Version: 1
  UpdatedAt: 2025-07-21 00:57:21.959910533 +0000 UTC
  NextUpdate: 2025-07-24 00:57:21.959910282 +0000 UTC
  DownloadedAt: 2025-07-22 00:03:12.262323 +0000 UTC
➜  trivy git:(main) ✗ 
➜  trivy git:(main) ✗ 
➜  trivy git:(main) ✗ ./trivy image 000000000000.dkr-ecr.ap-southeast-2.on.aws/private-image-tag:latest
2025-12-02T09:05:53+11:00       INFO    [vuln] Vulnerability scanning is enabled
2025-12-02T09:05:53+11:00       INFO    [secret] Secret scanning is enabled
2025-12-02T09:05:53+11:00       INFO    [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2025-12-02T09:05:53+11:00       INFO    [secret] Please see https://trivy.dev/docs/dev/guide/scanner/secret#recommendation for faster secret detection
2025-12-02T09:05:54+11:00       INFO    Detected OS     family="alpine" version="3.22.1"
2025-12-02T09:05:54+11:00       INFO    [alpine] Detecting vulnerabilities...   os_version="3.22" repository="3.22" pkg_num=29
2025-12-02T09:05:54+11:00       INFO    Number of language-specific files       num=1
2025-12-02T09:05:54+11:00       INFO    [python-pkg] Detecting vulnerabilities...
2025-12-02T09:05:54+11:00       WARN    Using severities from other vendors for some vulnerabilities. Read https://trivy.dev/docs/dev/guide/scanner/vulnerability#severity-selection for details.
2025-12-02T09:05:54+11:00       INFO    Table result includes only package filenames. Use '--format json' option to get the full path to the package file.

Report Summary

┌──────────────────────────────────────────────────────────────────────────────────┬────────────┬─────────────────┬─────────┐
│                                      Target                                      │    Type    │ Vulnerabilities │ Secrets │
├──────────────────────────────────────────────────────────────────────────────────┼────────────┼─────────────────┼─────────┤

@fischaz fischaz marked this pull request as ready for review December 1, 2025 22:08
@fischaz fischaz marked this pull request as draft December 1, 2025 22:17
@fischaz fischaz closed this Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants