fix: "manage users" button should close modal on settings page#6
Merged
mohanarpit merged 2 commits intoreleasefrom Jul 2, 2020
Merged
fix: "manage users" button should close modal on settings page#6mohanarpit merged 2 commits intoreleasefrom
mohanarpit merged 2 commits intoreleasefrom
Conversation
riodeuno
reviewed
Jul 1, 2020
Nikhil-Nandagopal
pushed a commit
that referenced
this pull request
Nov 3, 2020
Update import alias in the index.tsx and added some documentation in the README
7 tasks
1 task
1 task
Merged
2 tasks
subrata71
added a commit
that referenced
this pull request
Apr 5, 2026
…dropdown synchronization The test was failing intermittently because the click on .rc-tree-select-selector after deploy did not always open the dropdown. The root cause is a React hydration timing gap: the element is visible in the DOM before React attaches its event handlers, so the click fires but is swallowed silently, leaving the dropdown in its hidden state (rc-tree-select-dropdown-hidden with display: none). Prior fixes (409e03d, 2a262ac, d31ea85) all addressed DOM presence but not React readiness, so the flakiness persisted. This fix uses a two-phase approach: - Phase 1: A cy.waitUntil loop that clicks the selector and checks the library's own rc-tree-select-open class on the widget root. Only re-clicks when the dropdown is actually closed, preventing toggle oscillation. - Phase 2: Once open, waits for the specific "Green" option to be visible via cy.xpath().should("be.visible") before clicking it. Also closes the dropdown at the end of test #5 to prevent state leakage into test #6.
5 tasks
subrata71
added a commit
that referenced
this pull request
Apr 5, 2026
Replace fragile multi-step action selector UI setup with deterministic JS mode configuration, and add a conditional retry for the deployed TreeSelect dropdown click to handle widget remount timing during page hydration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.