chore: Skip tests in server build if no changes in server files for ok-to-test command

[rajatagrawal]

Fixes #24700

These changes will allow the CI to skip tests if there are no changes in server folder when using ok-to-test command. This will save CI minutes

[Aishwarya-U-R]

@rajatagrawal - can we do oktotest & test this out?

[rajatagrawal]

@rajatagrawal - can we do oktotest & test this out?

I am not sure how to do it, because it can only run if it is merged to release branch. I can test it if we add support for running ok-to-test command on a pull request if that is okay.

[sarojsarab]

@rajatagrawal - can we do oktotest & test this out?

I am not sure how to do it, because it can only run if it is merged to release branch. I can test it if we add support for running ok-to-test command on a pull request if that is okay.

@rajatagrawal I think you can update the test-build-docker-image.yml and run the workflow manually to check . Once done you can simply revert the changes before merge.

[rajatagrawal]

I have checked out the base code now using actions/checkout@v3. I don't know if I can access the pull request number if I use test-build-docker-image.yml and dispatch the event manually ? Any other suggested workarounds @sarojsarab ?

[sarojsarab]

I have checked out the base code now using actions/checkout@v3. I don't know if I can access the pull request number if I use test-build-docker-image.yml and dispatch the event manually ? Any other suggested workarounds @sarojsarab ?

@rajatagrawal You can hardcode the PR number.

[rajatagrawal]

@sarojsarab

I have tested the changes on test-build-docker-image.yml workflow.

These are the outputs of those test runs:

1. when server changes present, skip tests false : https://github.com/appsmithorg/appsmith/actions/runs/5330910644
2. when server changes not present, skip tests true : https://github.com/appsmithorg/appsmith/actions/runs/5330879566

[sarojsarab]

LGTM

[Aishwarya-U-R]

@sarojsarab

I have tested the changes on test-build-docker-image.yml workflow.

These are the outputs of those test runs:

1. when server changes present, skip tests false : https://github.com/appsmithorg/appsmith/actions/runs/5330910644
2. when server changes not present, skip tests true : https://github.com/appsmithorg/appsmith/actions/runs/5330879566

@rajatagrawal - Both these links are telling me Invalid workflow file?

[rajatagrawal]

@Aishwarya-U-R Can you please check Attempt #1 in both those links ? I think those links have two attempts. The ones that I have tested on are Attempt #1.

[rajatagrawal]

Attempt #2 is showing as missing workflow files because I moved the changes from test docker image yml file to ok-to-test yml file for the final commit.

[rajatagrawal]

@Aishwarya-U-R can you please merge it also ? This PR doesn't need a CI test run.

[Aishwarya-U-R]

@rajatagrawal - why is server build moved from parallel step with client build, please have this check alongside while having it at same level as client build like current:

[Aishwarya-U-R]

@rajatagrawal - Have server-build parallel to client build as now.

[rajatagrawal]

@Aishwarya-U-R

This diagram is from test docker build.yml which was only used for testing the workflow. The changes are actually moved
ok-to-test workflow after the changes work fine in it.

It is nonetheless parallel in test docker build yml as well, because in the workflow runs in this concerned screenshot, the server workflow ran after changeset passed. It didn't wait for client build.

I think that the diagram is showing that server has a dependency on client because all jobs i.e client/server/rds are required for the final build docker image job.

[Aishwarya-U-R]

Ah ok, Thanks much @sarojsarab for explaining me the same.
@rajatagrawal - merging this now - please have an eye on new runs to make sure our changes are actually doing ok!