Skip to content

feat: Ability to add new row in Table widget#17515

Merged
sbalaji1192 merged 13 commits intoreleasefrom
feat/add-new-row
Nov 5, 2022
Merged

feat: Ability to add new row in Table widget#17515
sbalaji1192 merged 13 commits intoreleasefrom
feat/add-new-row

Conversation

@sbalaji1192
Copy link
Copy Markdown
Contributor

@sbalaji1192 sbalaji1192 commented Oct 12, 2022 •
edited
Loading

Description

Introducing the ability to add a new row in the table widget.
Link to PRD - https://www.notion.so/appsmith/Adding-a-new-row-in-the-table-0ec90544d26c4c25ab1f9b2504e919a1

Fixes #13672

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added a new spec file with the following cases

Table widget Add new row feature

  • Basic flow
    should test that allow Add new row property is present
    should test that Add new row link appears on the UI when the allow add new row property is enabled
    should test that onSave, onDiscard and default row are showing up only when the allow add new property is enabled
    should test that add new row link is disabled during the inline editing flow
    should test that clicking on add new row link adds an empty row at the top of the table
    should test that editing is disabled when in add new row in progress
    should test that new row is getting populated with the default row property value
    should test that inline editing, row selection, pagination, search, filters are actions cannot be performed while in add new row feature
    should test that only editable column cells are in editmode in the new row
    should test that newRow property holds the entered data
    should test that non data (iconBitton, button, menubutton) column cells are not showing up
  • Validation flow
    should test that validation is working for a new row cell
    should test that validation variable isNewRow is working
    should test that validation is working for more than one add new row cell at a time
    should test that validation error message only appears when a cell is in focus
    should test that save button is disabled when there is an error
  • Actions flow (save, discard)
    should test that discard button is undoing the add new feature
    should test that discard events is triggered when user clicks on the discard button
    should test that save event is triggered when user clicks on the save button

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 2:32PM (UTC)

@sbalaji1192 sbalaji1192 marked this pull request as draft October 12, 2022 09:59
@github-actions github-actions bot added the Enhancement New feature or request label Oct 12, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 12, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@sbalaji1192
Copy link
Copy Markdown
Contributor Author

sbalaji1192 commented Oct 26, 2022

/ok-to-test sha=b054182

@sbalaji1192 sbalaji1192 marked this pull request as ready for review October 26, 2022 09:20
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets High This issue blocks a user from building or impacts a lot of users Table Widget labels Oct 26, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 26, 2022

Unable to find test scripts. Please add necessary tests to the PR.

6 similar comments
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 26, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 26, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 26, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 26, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 26, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 26, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 26, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3327905156.
Workflow: Appsmith External Integration Test Workflow.
Commit: b054182.
PR: 17515.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17515&runId=3327905156_1

ashit-rath
ashit-rath reviewed Oct 26, 2022
View reviewed changes
@sbalaji1192
Copy link
Copy Markdown
Contributor Author

sbalaji1192 commented Nov 3, 2022

/ok-to-test sha=53354d0

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 3, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3383176142.
Workflow: Appsmith External Integration Test Workflow.
Commit: 53354d0.
PR: 17515.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17515&runId=3383176142_1

@sbalaji1192
Copy link
Copy Markdown
Contributor Author

sbalaji1192 commented Nov 3, 2022

/ok-to-test sha=d40f77d

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 3, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3384975264.
Workflow: Appsmith External Integration Test Workflow.
Commit: d40f77d.
PR: 17515.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17515&runId=3384975264_1

ashit-rath
ashit-rath reviewed Nov 4, 2022
View reviewed changes
...t/cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/Inline_editing_spec.js Outdated
});

it("24. should check that doesn't grow taller when text wrapping is disabled", () => {
it.only("24. should check that doesn't grow taller when text wrapping is disabled", () => {
Copy link
Copy Markdown
Contributor

@ashit-rath ashit-rath Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the only be removed here and line 698?

@sbalaji1192
Copy link
Copy Markdown
Contributor Author

sbalaji1192 commented Nov 4, 2022

/ok-to-test=7b090f2

@sbalaji1192
Copy link
Copy Markdown
Contributor Author

sbalaji1192 commented Nov 5, 2022

/ok-to-test sha=7b090f2

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 5, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3398567971.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7b090f2.
PR: 17515.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17515&runId=3398567971_1

@sbalaji1192 sbalaji1192 merged commit 2df27a6 into release Nov 5, 2022
@sbalaji1192 sbalaji1192 deleted the feat/add-new-row branch November 5, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashit-rath ashit-rath ashit-rath approved these changes

Assignees

No one assigned

Labels

Enhancement New feature or request High This issue blocks a user from building or impacts a lot of users Table Widget Widgets Product This label groups issues related to widgets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Click to add a new row in the table

3 participants

@sbalaji1192 @kamakshibhat-appsmith @ashit-rath