Fix enrollment data backfill Django management command - #432
Merged
Conversation
Moving this because it is a pipeline module. Should have beeing in 'figures.pipeline' when first created
This commit simply adds a celery task wrapper to a pipeline function * Provides a Celery task to call the new pipeline function, `update_enrollment_data_for_course(course_id)` * Added unit test for this task
johnbaldwin
marked this pull request as ready for review
March 3, 2022 05:53
johnbaldwin
requested review from
OmarIthawi,
bryanlandia,
estherjsuh,
melvinsoft and
shadinaif
as code owners
March 3, 2022 05:53
* Significant rework uses the new 'workflow next' * The command module docstring and test code should have adequate documentation. Please read those
johnbaldwin
force-pushed
the
john/pipeline-enrollments-backfill
branch
from
March 3, 2022 05:56
2b3d2c5 to
61d8255
Compare
OmarIthawi
approved these changes
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
backfill_figures_enrollment_dataDjango management command to use new workflowfigures.backfilltofigures.pipeline.backfillbecause that's where it belongsAt the core, this is really just a convenience wrapper around
figures.tasks.backfill_enrollment_data_for_courseAs we use it, we'll iterate on CLI to improve usability.