Skip to content

Bump Figures version 0.3.15 and README#258

Merged
johnbaldwin merged 1 commit into
masterfrom
john/bump-0.3.15
Sep 11, 2020
Merged

Bump Figures version 0.3.15 and README#258
johnbaldwin merged 1 commit into
masterfrom
john/bump-0.3.15

Conversation

@johnbaldwin

@johnbaldwin johnbaldwin commented Sep 10, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter

codecov-commenter commented Sep 10, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #258 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          41       41           
  Lines        2134     2134           
=======================================
  Hits         1964     1964           
  Misses        170      170

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46857b1...7c9579c. Read the comment docs.

grozdanowski
grozdanowski suggested changes Sep 10, 2020
View reviewed changes

@grozdanowski grozdanowski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR 256 should not be merged in yet.

Comment thread README.rst Outdated
* Learner progress overview UI improvements, add to main menu

* https://github.com/appsembler/figures/pull/255
* https://github.com/appsembler/figures/pull/256

@grozdanowski grozdanowski Sep 10, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnbaldwin this PR is not to be merged at this point. It is to be merged upon actual release.

@johnbaldwin johnbaldwin Sep 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grozdanowski Updated to remove PR #256 from Figures 0.3.15

@johnbaldwin

johnbaldwin commented Sep 10, 2020

Copy link
Copy Markdown
Contributor Author

@grozdanowski Would you please approve this PR if you are satisfied with the README correction so I don't have to do an administrator override to commit?

@johnbaldwin
johnbaldwin merged commit 20b51b9 into master Sep 11, 2020
@johnbaldwin
johnbaldwin deleted the john/bump-0.3.15 branch September 11, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@thraxil thraxil thraxil approved these changes
@OmarIthawi OmarIthawi OmarIthawi approved these changes
@grozdanowski grozdanowski grozdanowski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@johnbaldwin @codecov-commenter @thraxil @OmarIthawi @grozdanowski