Use ManagedResource for volumes in CLI commands#1607
Open
katiewasnothere wants to merge 1 commit into
Open
Conversation
jglogan
reviewed
May 27, 2026
|
|
||
| public var tableRow: [String] { | ||
| [ | ||
| id, |
Contributor
There was a problem hiding this comment.
We don't have to do it today, but just wanted to get the thought out there.
If we switch ID over to a system-assigned identifier (for container, volume, network it'd be a 32 digit hex value like Docker), we'd probably want to report name and not id here. What do you think?
Contributor
Author
There was a problem hiding this comment.
Seems very reasonable to me. I'll change it to that.
| /// A volume resource, representing a configured volume. | ||
| public struct VolumeResource: ManagedResource { | ||
| /// The volume's configuration — its persistent, intrinsic properties. | ||
| public let config: Volume |
Contributor
There was a problem hiding this comment.
Again not necessarily for this PR Volume become VolumeConfiguration?
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
047157b to
c472271
Compare
Code Coverage
|
jglogan
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Related to #1404.
This PR adds the initial work to have volume resources conform to ManagedResource, in alignment with other resources such as networks (see here). Further work is necessary to move the use of
VolumeResourcedown to the APIServer (in the VolumesService) and in the volume client. Volumes do not currently have any plugin or runtime state, so that information is not included in theVolumeResource, but could be added later if needed.Testing