cli: resolve subcommand path in container help#1587
Open
0xMH wants to merge 2 commits into
Open
Conversation
3133def to
965d320
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Fixes #1509. The CLI's own help text tells users to run
container help <subcommand>, but every form of that errored:The project's custom
HelpCommand(registered so plugins show up in top-level help) had no positional@Argument, so swift-argument-parser routedhelp <x>to it and rejected the trailing tokens. Added a captured subcommand path, walkedApplication'ssubcommands+groupedSubcommandstree (matchingcommandNameandaliases), and printedApplication.helpMessage(for:)for the resolved target. Empty path keeps existing plugin-aware top-level help; unknown path throwsValidationError.Testing