Skip to content

Conversation

@titusfortner
Copy link
Contributor

I'd also be ok if we didn't do the extra work to require the version check in the first place, but this makes the minimal changes to the existing code.

@titusfortner titusfortner requested a review from KazuCocoa April 12, 2017 16:22
@jsf-clabot
Copy link

jsf-clabot commented Apr 12, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KazuCocoa KazuCocoa mentioned this pull request Apr 12, 2017
@KazuCocoa KazuCocoa added this to the v9.3.8 milestone Apr 12, 2017
@KazuCocoa KazuCocoa merged commit 5e67b88 into master Apr 12, 2017
@KazuCocoa
Copy link
Member

KazuCocoa commented Apr 12, 2017

@titusfortner I've published ruby_lib as v9.3.8

@KazuCocoa KazuCocoa deleted the version_check branch April 21, 2017 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants