find elements except for name attributes in text/s, button/s

[KazuCocoa]

Previous find_exact/s/text/s/button/s search words which match with name, value and label attributes like the following attributes. This method is based on UIAutomation script directly.

    def string_visible_contains(element, value)
      contains = {
        target:      value,
        substring:   true,
        insensitive: true
      }

      {
        typeArray:   [element],
        onlyVisible: true,
        name:        contains,
        label:       contains,
        value:       contains
      }
    end

---

In XCUITest, this library used :xpath strategy before 9.1.3 to find elements. But the results differ from UIAutomation. (e.g. button's tests)

In 9.1.3+, button/s and test/s use find_elements :name, "something" to avoid using xpath to improve the performance. But this results not same as previous one yet. e.g. button's test
I think, we should use elements not only name but also label and value.( in WDA, they are

---

• How to improve

1. get elements with find_elements :name, "something" and check their label and value , visibility attributes in ruby script.
   • WDA can search identifier with :name, :id, accessibility id or -ios predicate string . xcuitest-driver, WDA
   • So, we can check other attributes after getting elements.
2. use : predicate instead of UIAutomation script directly.

[KazuCocoa]

I checked the difference among id, name and accessibility id with this repository's test app.

[13] pry(#<ios/element/button>)> e1 = find_elements id: "Back"
=> [#<Selenium::WebDriver::Element:0x188b0ba5725e56dc id="F4DC13DF-94EA-4870-B745-5D8D079FE927">,
 #<Selenium::WebDriver::Element:0x261dd5aab1286bb6 id="97925CBF-9E06-48DA-8656-2C5A8AB501D7">]
[14] pry(#<ios/element/button>)> e2 = find_elements id: "Back"
=> [#<Selenium::WebDriver::Element:0x..faaa5bdc3552ba02a id="B864A23B-D2B0-4998-B8DF-6D57BEB646B1">,
 #<Selenium::WebDriver::Element:0x..f6792b16459b465e id="09F5ADCD-E00B-4491-A807-2A72461420EF">]
[15] pry(#<ios/element/button>)> e3 = find_elements accessibility_id: "Back"
=> [#<Selenium::WebDriver::Element:0x3027ef02daf91984 id="5E9C9284-0A73-4564-83BB-3EA5E1CCA4BD">,
 #<Selenium::WebDriver::Element:0x5131748b99d27a0c id="A2B88102-CC5B-43DB-8CEA-1FBFF1B10CFB">]

I can get same value for each .value and .text, and .name and .label against button/text.
The difference between previous(before v9.1.3) and 9.1.3+ is visibility check.

---

We can get the same element with find_element :id, "something" and find_element :name, "something".

[16] pry(#<ios/element/button>)> e = find_element :id, "Normal"
=> #<Selenium::WebDriver::Element:0x3f753c6dd30f95a2 id="E5B02D0D-5B43-409D-86A7-9606D3C73BE2">
[17] pry(#<ios/element/button>)> e.value
=> "<enter text>"
[18] pry(#<ios/element/button>)> f = find_element :id, "<enter text>"
=> #<Selenium::WebDriver::Element:0x..f833b30a857046296 id="AD18BBA6-52F3-4EEE-88F8-D939DEB7E3CA">
[19] pry(#<ios/element/button>)> f.value
=> "<enter text>"

[KazuCocoa]

https://github.com/KazuCocoa/ruby_lib/tree/return_visible_elements

[KazuCocoa]

FYI @slipy12
I'v investigated the issue you mentioned before on slack and clarified the cause.
Its main reason is associated with visibility.

Previous logic only get visible elements. But current ones get all elements.
So, I add visibility check after getting elements from WebDriverAgent in #465 .

Tests also works fine as same as previous logic.

---

I added visibility check for text/s, button/s, tag/s and textfield/s.