Add handlers for locking/unlocking the screen#21
Merged
Conversation
umutuzgur
reviewed
Jan 2, 2018
| if (fb_isLocked) { | ||
| return YES; | ||
| } | ||
| SEL mSelector = NSSelectorFromString(@"pressLockButton"); |
Member
There was a problem hiding this comment.
@mykola-mokhnach As you suggested, lets get rid of this by importing #import "XCUIDevice.h". This method exists in the private headers
umutuzgur
reviewed
Jan 2, 2018
| [self pressButton:XCUIDeviceButtonHome]; | ||
| [[NSRunLoop currentRunLoop] runUntilDate:[NSDate dateWithTimeIntervalSinceNow:FBHomeButtonCoolOffTime]]; | ||
| if (SYSTEM_VERSION_LESS_THAN(@"10.0")) { | ||
| [[FBApplication fb_activeApplication] swipeRight]; |
umutuzgur
reviewed
Jan 2, 2018
| return YES; | ||
| } | ||
| [self pressButton:XCUIDeviceButtonHome]; | ||
| [[NSRunLoop currentRunLoop] runUntilDate:[NSDate dateWithTimeIntervalSinceNow:FBHomeButtonCoolOffTime]]; |
Member
There was a problem hiding this comment.
I don't think you need this. Usually higher XCUITest apis already have this cool off implemented or have you seen a case that this was needed?
Author
There was a problem hiding this comment.
there is a comment in the code that it was the case in 9.3. I'd rather keep the delay, since there is anyway an animation delay there and XCTest does not really like animations.
umutuzgur
reviewed
Jan 2, 2018
| [[FBRoute POST:@"/wda/deactivateApp"] respondWithTarget:self action:@selector(handleDeactivateAppCommand:)], | ||
| [[FBRoute POST:@"/wda/keyboard/dismiss"] respondWithTarget:self action:@selector(handleDismissKeyboardCommand:)], | ||
| [[FBRoute GET:@"/lock"].withoutSession respondWithTarget:self action:@selector(handleLock:)], | ||
| [[FBRoute POST:@"/wda/lock"].withoutSession respondWithTarget:self action:@selector(handleLock:)], |
Member
There was a problem hiding this comment.
I think this is actually a PUT since the end state is always a locked screen, I'm not considering the case of it failing since it is irrelevant in http methods. The same applies to unlock
Author
There was a problem hiding this comment.
I'd rather follow the general pattern.
umutuzgur
reviewed
Jan 2, 2018
| }, | ||
| @"scale": @([FBScreen scale]) | ||
| @"scale": @([FBScreen scale]), | ||
| @"locked": @([[XCUIDevice sharedDevice] fb_isScreenLocked]) |
Member
|
I'm closing my PR. Cool solution for below iOS 10! |
Author
|
@imurchie can you please take a look at this PR? |
imurchie
approved these changes
Jan 4, 2018
imurchie
left a comment
There was a problem hiding this comment.
One little typo. Otherwise looks good.
| /** | ||
| Checks if the screen is locked or not. | ||
|
|
||
| @return YES if if screen is locked |
3 tasks
followthemoney1
added a commit
to FlutterFastCom/WebDriverAgent
that referenced
this pull request
May 10, 2026
Phase-1 empirical test on iPhone 14 Pro / iOS 26.1 (2026-05-10) showed bundle never appeared in Settings → Privacy & Security → Photos because prior code skipped requestAuthorization on .notDetermined and treated it as unsupported. iOS test runners have no UI surface to display the permission prompt, so iOS auto-denies — but the call still registers the bundle in the TCC database. Once registered, /wda/system/photos-permission/grant (TIER 3b endpoint appium#21, F-WDA-FORK-EXTENSIONS) can auto-navigate Settings to tap Full Access; OR user grants manually one-time per device. Empirically verified post-patch: /wda/photos/list returns assets, /wda/photos/import returns valid assetIdentifier in 209ms, /wda/photos/importBatch atomic transaction succeeds in 85ms total across 2 assets, pushed images visible in iPhone Photos.app within 30s. Phase-1 critical visual gate: PASSED. WDA-fork approach validated. Refs: docs/business/features/approved/F-WDA-FORK-EXTENSIONS.md Refs: tasks/2026-05-09-wda-fork-extensions.md Phase 1 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR superseeds #8 by @umutuzgur
I've also added integrations tests, fixed minor issues + screen unlock for iOS < 10