Bump github.com/stretchr/testify from 1.8.0 to 1.8.3#21
Open
dependabot[bot] wants to merge 3 commits intomainfrom
Open
Bump github.com/stretchr/testify from 1.8.0 to 1.8.3#21dependabot[bot] wants to merge 3 commits intomainfrom
dependabot[bot] wants to merge 3 commits intomainfrom
Conversation
This is to address a specific issue we have in connecting to a large exchange where our message rate is limited by the exchange at varying levels between testing and production environments. Breaching those limits causes our client to be disconnected so we need this guard in place to ensure we do not inadvertantly burst over the limit should we queue a large number of messages to be sent during the next iteration of the writeLoop. We also instrument the sending/receiving functions using Prometheus counters. This is added for maximum observability but isn't fully thought through Here we should probably allow the caller of the library to pass in a registerer so the caller has more control of this. This change is quick and dirty one to see if we can see these values on our application metrics
Add message rate limit to initiator and instrument
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.0 to 1.8.3. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.0...v1.8.3) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
smulube
pushed a commit
that referenced
this pull request
Jun 3, 2024
…til sent (#21) ## Issue When log on request was queued because cannot be send due to connection not ready, Then it goes through the [main session loop](https://github.com/alpacahq/quickfix/blob/5dcde41f3e6e68e93e1fd381761cd9c7843aec43/session.go#L821-L841) which leads to [SendAppMessages](https://github.com/alpacahq/quickfix/blob/5dcde41f3e6e68e93e1fd381761cd9c7843aec43/session_state.go#L107-L111) But, since session is not logged on yet because the message queued is the log on message, we drop the `toSend` queued messages so we lose the log on message itself. ## Proposed solution For important messages like Logon/Logout/Resend/SequenceReset we block until sent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/stretchr/testify from 1.8.0 to 1.8.3.
Commits
4c93d8fEqualExportedValues: Handle nested pointer, slice and map fields (#1379)4b2f4d2add EventuallyWithT assertion (#1264)b3106d7allow testing for functional options (#1023)437071bassert: fix error message formatting for NotContains (#1362)c5fc9d6Compare public elements of struct (#1309)f36bfe3Fix Subset/NotSubset when map is missing keys from the subset (#1261)0ab3ce1FixCallerInfo()source file paths (#1288)2b00d33Fix Call.Unset() panic (issue #1236) (#1250)9acc222fix: fix bug for check unsafe.Pointer isNil (#1319)1333b5dAdd sub-tests to Suite (#1246)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)