docs: retro for code review + AI Literacy Course ordering fix#37
Merged
Conversation
Actions from retro: - CLAUDE.md: new Git workflow section (always branch; fetch before diffing main) - CLAUDE.md: on-device install-marker subsection (bump INSTALL_VERSION on extraction/generation changes) + assemblePlugin/downloadAssets silent-failure warning - learnings.md: plugin build & install gotchas - retrospective.md: 2026-07-01 entry
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrospective and process-doc updates from the 2026-07-01 session (high-effort code review on PR #31 + the AI Literacy Course ordering fix in #36).
What changed
CLAUDE.mdmain);git fetchand compare againstorigin/mainbefore any diff-against-main. A stale localmaincaused a/code-reviewthis session to flag 3 findings outside the actual PR diff.CourseShell.generate()) must bumpCourseInstaller.INSTALL_VERSION, or existing installs skip the work and the fix has no on-device effect.assemblePlugindoes not rundownloadAssetsand silently ships a broken.cgpwhen assets (e.g.pdfjs.zip) are missing — verify assets before trusting the.cgp.docs/process/learnings.mddocs/process/retrospective.md2026-07-01entry: time breakdown, observations, feedback, and actions.Why
Encodes three pieces of session feedback so they don't recur: branch discipline, fetch-before-diff, and bumping
INSTALL_VERSIONalongside generation-logic changes (which cost a device round-trip this session).Docs-only; no code or plugin behavior changes.