Skip to content

docs: retro for code review + AI Literacy Course ordering fix#37

Merged
hal-eisen-adfa merged 1 commit into
mainfrom
docs/retro-2026-07-01
Jul 1, 2026
Merged

docs: retro for code review + AI Literacy Course ordering fix#37
hal-eisen-adfa merged 1 commit into
mainfrom
docs/retro-2026-07-01

Conversation

@hal-eisen-adfa

Copy link
Copy Markdown
Contributor

Retrospective and process-doc updates from the 2026-07-01 session (high-effort code review on PR #31 + the AI Literacy Course ordering fix in #36).

What changed

CLAUDE.md

  • New Git workflow section: always work on a branch (never commit to main); git fetch and compare against origin/main before any diff-against-main. A stale local main caused a /code-review this session to flag 3 findings outside the actual PR diff.
  • New One-time on-device install markers subsection: any change to extraction or post-extraction generation (e.g. CourseShell.generate()) must bump CourseInstaller.INSTALL_VERSION, or existing installs skip the work and the fix has no on-device effect.
  • Expanded Asset downloads: a bare assemblePlugin does not run downloadAssets and silently ships a broken .cgp when assets (e.g. pdfjs.zip) are missing — verify assets before trusting the .cgp.

docs/process/learnings.md

  • New "Plugin build & install gotchas" section covering the two traps above.

docs/process/retrospective.md

  • New 2026-07-01 entry: time breakdown, observations, feedback, and actions.

Why

Encodes three pieces of session feedback so they don't recur: branch discipline, fetch-before-diff, and bumping INSTALL_VERSION alongside generation-logic changes (which cost a device round-trip this session).

Docs-only; no code or plugin behavior changes.

Actions from retro:
- CLAUDE.md: new Git workflow section (always branch; fetch before diffing main)
- CLAUDE.md: on-device install-marker subsection (bump INSTALL_VERSION on
  extraction/generation changes) + assemblePlugin/downloadAssets silent-failure warning
- learnings.md: plugin build & install gotchas
- retrospective.md: 2026-07-01 entry

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@hal-eisen-adfa hal-eisen-adfa merged commit 8306d45 into main Jul 1, 2026
@hal-eisen-adfa hal-eisen-adfa deleted the docs/retro-2026-07-01 branch July 1, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant