ADFA-4593: help mechanism fixes (LOHS wiring + smart tooltip placement)#155
Merged
Merged
Conversation
added 2 commits
July 8, 2026 04:16
…er help The LocalOnlyHotspot section (Usage > Advanced settings, ADFA-4520) was added after the initial wiring inventory, so its enable checkbox and 'Show Wi-Fi QR' button had no tooltip. Add both to the TooltipWiring registry + TooltipTag.
… screen PopupWindow.showAsDropDown always placed the tooltip below the anchor, so controls near the bottom (webview/portal nav bar, QR close button) had their tooltip clipped off the bottom edge. Now, when the anchor sits in the lower part of the screen, the popup is shown above it (bottom edge over the anchor top) via showAtLocation with bottom gravity — anchor-position based, so it works even while the WebView content is still laying out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADFA-4593 — Help mechanism fixes
Two small mechanism improvements so the three-tier help is fully inspectable on device, ahead of the content PR.
1. Wire the LOHS controls
The LocalOnlyHotspot section (Usage > Advanced settings, ADFA-4520) was added after the initial wiring inventory, so its enable checkbox (lohs_toggle) and "Show Wi-Fi QR" button (lohs_show_qr) had no tooltip. Added both to the TooltipWiring registry + TooltipTag.
2. Smart tooltip placement (above/below)
PopupWindow.showAsDropDown always placed the tooltip below the anchor, so controls near the bottom (webview/portal nav bar, QR close button) had their tooltip clipped off the bottom. Now, when the anchor sits in the lower part of the screen, the popup is shown above it (bottom edge over the anchor top) via showAtLocation with bottom gravity. Anchor-position based, so it works even while the WebView content is still laying out.
Notes
Relates to ADFA-4536; part of ADFA-4593.