ADFA-4326: Guard uninitialized projectPath on process-death recreation

[fryanpan]

Jira Ticket: https://appdevforall.atlassian.net/browse/ADFA-4326
Sentry Issue: https://appdevforall-inc-9p.sentry.io/issues/APPDEVFORALL-QZ

Reproduction Details

After process death the OS can recreate EditorActivity without routing through MainActivity, leaving ProjectManagerImpl's lateinit projectPath unset. EditorActivity reads projectDirPath during onCreate (via EditorViewModel.getProjectName → projectDir → projectDirPath); the getter delegated straight to the lateinit and threw UninitializedPropertyAccessException, failing activity start.

Stack Trace

RuntimeException: Unable to start activity ComponentInfo{….EditorActivityKt}:
  kotlin.UninitializedPropertyAccessException: lateinit property projectPath has not been initialized
    at com.itsaky.androidide.projects.ProjectManagerImpl.getProjectPath(SourceFile:7)
    at com.itsaky.androidide.projects.ProjectManagerImpl.getProjectDirPath(SourceFile)
    at com.itsaky.androidide.viewmodel.EditorViewModel.getProjectName(SourceFile:6)
    at com.itsaky.androidide.activities.editor.BaseEditorActivity.onCreate(SourceFile:159)
    at com.itsaky.androidide.activities.editor.ProjectHandlerActivity.onCreate(...)
    at com.itsaky.androidide.activities.editor.EditorHandlerActivity.onCreate(SourceFile:8)

User Steps

User steps leading up to crash, based on Sentry breadcrumbs:

• The process was recreated while the device was still locked (breadcrumb: BaseApplication: Creating safe context because user is not unlocked → direct-boot / credential-protected storage), then EditorActivity/EditorSidebarFragment are recreated with no project context → crash on first projectPath access.

Was able to reproduce in a unit test?

Yes.
ProjectManagerImplUninitializedPathTest (:subprojects:projects, Robolectric) constructs a fresh ProjectManagerImpl (projectPath never set = the process-death state) and reads projectDirPath/projectDir. Baseline: 2/3 cases FAIL with UninitializedPropertyAccessException (the 3rd, initialized, passes — not a tautology). Branch: 3/3 pass.

What Was Fixed

Guarded getter — get() = if (this::projectPath.isInitialized) projectPath else "" — and EditorViewModel/BaseEditorActivity route back to MainActivity instead of crashing when there's no project context.

Testing

:subprojects:projects:testV8DebugUnitTest → 3/3 green (red on baseline). Local CodeRabbit review: no findings. Reviewer notes (local): the finish()+return only exits BaseEditorActivity.onCreate — subclass onCreate (services/LSP/initializeProject) still runs on the finishing activity; consider short-circuiting earlier / isFinishing guards. The EditorViewModel blank-path guard is redundant with the getter fix. Recommend an android-qa smoke of the process-death → editor-recreation path before close.

---

Fixes APPDEVFORALL-QZ

[coderabbitai]

📝 Walkthrough

• Fixed a crash in EditorActivity after process-death recreation by preventing ProjectManagerImpl.projectDirPath from throwing when projectPath was never initialized.
• BaseEditorActivity now attempts to restore the project path from saved state, the launch intent, or the last opened project, and safely routes users back to MainActivity if no valid project context is available.
• EditorViewModel now handles missing project context by returning an empty project name instead of dereferencing an unset project directory.
• Added Robolectric coverage for the uninitialized-path case and confirmed the initialized-path behavior still works.

Risks / best-practice notes:

• Returning an empty string for an uninitialized project path may hide configuration issues if callers do not explicitly handle the “no project loaded” state.
• Redirecting to MainActivity on missing context improves stability, but it may surprise users if process recreation happens unexpectedly and their editor session cannot be restored.

Walkthrough

The PR makes project-path restoration resilient during editor recreation, avoids uninitialized project-path crashes in project accessors, and updates editor name lookup to return an empty string when no project path is available.

Changes

Project path recovery

Layer / File(s)	Summary
Project path access and coverage subprojects/projects/src/main/java/com/itsaky/androidide/projects/ProjectManagerImpl.kt, subprojects/projects/src/test/java/com/itsaky/androidide/projects/ProjectManagerImplUninitializedPathTest.kt	projectDirPath returns "" until projectPath is initialized, and the new Robolectric test checks blank and initialized reads.
Editor startup restoration and name lookup app/src/main/java/com/itsaky/androidide/activities/editor/BaseEditorActivity.kt, app/src/main/java/com/itsaky/androidide/viewmodel/EditorViewModel.kt	BaseEditorActivity restores the project path from saved state, intent, or GeneralPreferences, then finishes through MainActivity when projectDirPath is blank; EditorViewModel.getProjectName() returns "" for the blank-path case.

Sequence Diagram(s)

sequenceDiagram
  participant BaseEditorActivity
  participant GeneralPreferences
  participant ProjectManagerImpl
  participant MainActivity
  BaseEditorActivity->>GeneralPreferences: read lastOpenedProject when saved state and intent are blank
  BaseEditorActivity->>ProjectManagerImpl: assign restored projectPath
  BaseEditorActivity->>ProjectManagerImpl: read projectDirPath after super.onCreate
  alt projectDirPath is blank
    BaseEditorActivity->>MainActivity: navigate back
    BaseEditorActivity->>BaseEditorActivity: finish()
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• appdevforall/CodeOnTheGo#858: Also changes BaseEditorActivity.onCreate to restore ProjectManagerImpl.projectPath earlier during editor recreation.
• appdevforall/CodeOnTheGo#1057: Also uses ProjectManagerImpl.projectDirPath for editor-state validation and project-scoped behavior.

Suggested reviewers

• jatezzz
• Daniel-ADFA

Poem

A bunny hopped through saved-state hay,
and found the project path today.
If the burrow’s blank, we turn around—
hop home to MainActivity ground.
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 71.43% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main fix: guarding an uninitialized projectPath during process-death recreation.
Description check	✅ Passed	The description directly explains the crash, fix, and added regression test for the same issue.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ADFA-4326-editoractivity-uninitialized-projectpath

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

app/src/main/java/com/itsaky/androidide/activities/editor/BaseEditorActivity.kt (1)

645-652: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Extract the "PROJECT_PATH" intent-extra key into a shared constant.

This literal is the producer/consumer contract with MainActivity (putExtra("PROJECT_PATH", ...) at MainActivity.kt:427). Duplicating the raw string in both places risks silent drift if either side is renamed. Consider a single const val referenced by both.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@app/src/main/java/com/itsaky/androidide/activities/editor/BaseEditorActivity.kt`
around lines 645 - 652, The PROJECT_PATH intent extra is duplicated as a raw
string in the editor restore flow, which can drift from the sender in
MainActivity. Introduce a shared constant for the intent-extra key and update
BaseEditorActivity’s restoredProjectPath lookup and MainActivity’s putExtra call
to use that symbol consistently, so the producer/consumer contract stays
centralized and easy to rename safely.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@app/src/main/java/com/itsaky/androidide/activities/editor/BaseEditorActivity.kt`:
- Around line 645-652: The PROJECT_PATH intent extra is duplicated as a raw
string in the editor restore flow, which can drift from the sender in
MainActivity. Introduce a shared constant for the intent-extra key and update
BaseEditorActivity’s restoredProjectPath lookup and MainActivity’s putExtra call
to use that symbol consistently, so the producer/consumer contract stays
centralized and easy to rename safely.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 248653b1-f8b7-4793-92e8-c7b478044b1c

📥 Commits

Reviewing files that changed from the base of the PR and between 97e5c06 and 9f8ab42.

📒 Files selected for processing (4)

• app/src/main/java/com/itsaky/androidide/activities/editor/BaseEditorActivity.kt
• app/src/main/java/com/itsaky/androidide/viewmodel/EditorViewModel.kt
• subprojects/projects/src/main/java/com/itsaky/androidide/projects/ProjectManagerImpl.kt
• subprojects/projects/src/test/java/com/itsaky/androidide/projects/ProjectManagerImplUninitializedPathTest.kt