fix(hydra): resolve related class when hydra_prefix is false #166
+416
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When hydra_prefix is not set to true, owl:onProperty uses bare "member" which jsonld.expand resolves via @vocab (e.g. "http://localhost/docs.jsonld#member") instead of "http://www.w3.org/ns/hydra/core#member". This caused Strategy 1 in findRelatedClass to fail. For read-only resources without a POST operation, Strategy 2 also fails, resulting in "Cannot find the class related to..." errors. Relax the onProperty check from exact match to endsWith("#member") so both the correct hydra IRI and the @vocab-expanded IRI are accepted. Closes api-platform#147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hydra_prefix is not set to true, owl:onProperty uses bare "member"
which jsonld.expand resolves via @vocab (e.g. "http://localhost/docs.jsonld#member")
instead of "http://www.w3.org/ns/hydra/core#member". This caused Strategy 1
in findRelatedClass to fail. For read-only resources without a POST operation,
Strategy 2 also fails, resulting in "Cannot find the class related to..." errors.
Relax the onProperty check from exact match to endsWith("#member") so both
the correct hydra IRI and the @vocab-expanded IRI are accepted.
Closes #147