TS-4759: Fix stream states management#999
Merged
masaori335 merged 1 commit intoapache:masterfrom Sep 12, 2016
Merged
Conversation
- Change stream state from IDLE or OPEN to HALF_CLOSED_LOCAL when send a frame w/ END_STREAM - Make send_a_data_frame to return HTTP2_SEND_A_DATA_FRAME_DONE when send DATA frame w/ END_STREAM - Set stream state CLOSED when error is happen
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/762/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/658/ for details. |
Member
|
The changes look reasonable to me. Separate tracking sending EOS and receiving EOS seems like a good idea |
Member
|
Looks OK. I understand the necessity of doing this but I'm not thrilled adding more state flags to Http2Stream class. I can live with them but I hope they are managed in |
bneradt
pushed a commit
to bneradt/trafficserver
that referenced
this pull request
Nov 26, 2024
…1823) (apache#999) Co-authored-by: David Carlin <dcarlin@yahoo-inc.com> (cherry picked from commit 9cf559a) Co-authored-by: David Carlin <dcarlin@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Below is the situation when this failure is happen.
closed.There are two problems.
half-close (local).And send RST_STREAM frame to client and make state
closed.To fix this
half-close (local)fromidleoropenwhen send a frame w/ END_STREAM flag