Skip to content

Replace httpbin with go-httpbin #9475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bneradt merged 7 commits into from
Mar 1, 2023
Merged

Replace httpbin with go-httpbin #9475

bneradt merged 7 commits into from
Mar 1, 2023

Conversation

@bneradt
Copy link
Contributor

@bneradt bneradt commented Mar 1, 2023

The Python httpbin is no longer maintained and has dependency issues upon an old Werkzeug from which we would like to unpin. This converts our tests to using go-httpbin instead of the Python httpbin module.

@bneradt bneradt added the AuTest label Mar 1, 2023
@bneradt bneradt added this to the 10.0.0 milestone Mar 1, 2023
@bneradt bneradt requested a review from masaori335 March 1, 2023 03:34
@bneradt bneradt self-assigned this Mar 1, 2023
brbzull0
brbzull0 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@brbzull0 brbzull0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Brian

@bneradt bneradt merged commit 796391e into apache:master Mar 1, 2023
@bneradt bneradt deleted the use_go_httpbin branch March 1, 2023 15:32
This was referenced Mar 1, 2023
Closed
Open
@masaori335 masaori335 mentioned this pull request Jun 14, 2023
Closed
bneradt added a commit to bneradt/trafficserver that referenced this pull request Jul 5, 2023
@bneradt
Replace httpbin with go-httpbin (apache#9475)
1887d59 
The Python httpbin is no longer maintained and has dependency issues upon an old Werkzeug from which we would like to unpin. This converts our tests to using go-httpbin instead of the Python httpbin module.

(cherry picked from commit 796391e)

Conflicts:
      tests/gold_tests/proxy_protocol/gold/test_case_0_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_1_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_2_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_3_stderr.gold
      tests/gold_tests/proxy_protocol/gold/test_case_3_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_4_stderr.gold
      tests/gold_tests/proxy_protocol/gold/test_case_4_stdout.gold
bneradt added a commit to bneradt/trafficserver that referenced this pull request Jul 5, 2023
@bneradt
Replace httpbin with go-httpbin (apache#9475)
f5a85ea 
The Python httpbin is no longer maintained and has dependency issues upon an old Werkzeug from which we would like to unpin. This converts our tests to using go-httpbin instead of the Python httpbin module.

(cherry picked from commit 796391e)

Conflicts:
      tests/gold_tests/proxy_protocol/gold/test_case_0_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_1_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_2_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_3_stderr.gold
      tests/gold_tests/proxy_protocol/gold/test_case_3_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_4_stderr.gold
      tests/gold_tests/proxy_protocol/gold/test_case_4_stdout.gold
zwoop pushed a commit that referenced this pull request Jul 5, 2023
@bneradt @midchildan
92x autest updates (#9952)
92eebcd 
* Fix autest for OpenSSL 3.0 (#9753)

* Fix forward-non-http autest for OpenSSL 3.0

* Fix tls-verify-override autest for OpenSSL 3.0

* Fix tls_client_versions autest with OpenSSL 3.0

* Update test-nc-s_client.sh

Added an EOF to test-nc-s_client.sh

(cherry picked from commit e6d2fb1)

Conflicts:
      tests/gold_tests/tls/test-nc-s_client.sh

* Fix autests for fedora 38 (#9881)

I ran autest on fedora:38 and noticed that all but three passed. This commit updates our autests to work with the newer openssl s_client and Python3.11.

The most significant set of changes come from hyper being abandoned an no longer working on Python 3.11. This converts the ad-hoc clients we had written in hyper to the h2 framework.

(cherry picked from commit 4310521)

* Replace httpbin with go-httpbin (#9475)

The Python httpbin is no longer maintained and has dependency issues upon an old Werkzeug from which we would like to unpin. This converts our tests to using go-httpbin instead of the Python httpbin module.

(cherry picked from commit 796391e)

Conflicts:
      tests/gold_tests/proxy_protocol/gold/test_case_0_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_1_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_2_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_3_stderr.gold
      tests/gold_tests/proxy_protocol/gold/test_case_3_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_4_stderr.gold
      tests/gold_tests/proxy_protocol/gold/test_case_4_stdout.gold

* Updates for the new go-httpbin v2.6.0 release. (#9633)

go-httpbin@v2.6.0 fixes /bytes/0 to actually return 0 bytes. This patch
accommodates our autests for that fix and any other behavioral changes.

(cherry picked from commit a9cb994)

* Fix test_tsapi.cc shutdown crash

The global namespace destructor for the test_tsapi.cc used in
tsapi.test.py would crash on shutdown. This does the cleanup in a
shutdown handler rather than in the global namespace.

---------

Co-authored-by: midchildan <git@midchildan.org>
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Sep 26, 2023
@bneradt @midchildan @masaori335
92x autest updates (apache#9952)
b40dc4b 
* Fix autest for OpenSSL 3.0 (apache#9753)

* Fix forward-non-http autest for OpenSSL 3.0

* Fix tls-verify-override autest for OpenSSL 3.0

* Fix tls_client_versions autest with OpenSSL 3.0

* Update test-nc-s_client.sh

Added an EOF to test-nc-s_client.sh

(cherry picked from commit e6d2fb1)

Conflicts:
      tests/gold_tests/tls/test-nc-s_client.sh

* Fix autests for fedora 38 (apache#9881)

I ran autest on fedora:38 and noticed that all but three passed. This commit updates our autests to work with the newer openssl s_client and Python3.11.

The most significant set of changes come from hyper being abandoned an no longer working on Python 3.11. This converts the ad-hoc clients we had written in hyper to the h2 framework.

(cherry picked from commit 4310521)

* Replace httpbin with go-httpbin (apache#9475)

The Python httpbin is no longer maintained and has dependency issues upon an old Werkzeug from which we would like to unpin. This converts our tests to using go-httpbin instead of the Python httpbin module.

(cherry picked from commit 796391e)

Conflicts:
      tests/gold_tests/proxy_protocol/gold/test_case_0_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_1_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_2_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_3_stderr.gold
      tests/gold_tests/proxy_protocol/gold/test_case_3_stdout.gold
      tests/gold_tests/proxy_protocol/gold/test_case_4_stderr.gold
      tests/gold_tests/proxy_protocol/gold/test_case_4_stdout.gold

* Updates for the new go-httpbin v2.6.0 release. (apache#9633)

go-httpbin@v2.6.0 fixes /bytes/0 to actually return 0 bytes. This patch
accommodates our autests for that fix and any other behavioral changes.

(cherry picked from commit a9cb994)

* Fix test_tsapi.cc shutdown crash

The global namespace destructor for the test_tsapi.cc used in
tsapi.test.py would crash on shutdown. This does the cleanup in a
shutdown handler rather than in the global namespace.

---------

Co-authored-by: midchildan <git@midchildan.org>
(cherry picked from commit 92eebcd)
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
@zwoop
Merge remote-tracking branch 'asf/master'
6f2cf2f 
* asf/master: (28 commits)
  Human readable timestamp for traffic_ctl config status (apache#9440)
  traffic_ctl - Remove legacy/pretty format output options (apache#9471)
  TSAN fix for fake_global_for_ink_queue. (apache#9183)
  libswoc: replace TextView in src/tscore/HostLookup.cc (apache#9437)
  records.yaml: Make sure when a string field is set to NULL then this (apache#9472)
  QUIC: Make sure the some of the quic configs get set into the quiche impl. (apache#9477)
  Replace httpbin with go-httpbin (apache#9475)
  Ethread::process_event(): make sure event mutex is unlocked before freeing event. (apache#9433)
  Use deprecated OpenSSL APIs for MD5 and SHA256 if available (apache#9469)
  Adds a --enable-lto option (Link Time Optimization) (apache#9464)
  traffic_ctl: Add support to monitor metrics. (apache#9423)
  QUIC: Make some adjustment to the qlog configuration (apache#9461)
  Added more debugging output for the xdebug plugin (apache#9467)
  Build: remove configure check for sys/mount.h, use C++17 builtin. (apache#9463)
  Fix SSLSessionDup for old OpenSSL and BoringSSL (apache#9444)
  Run autest tls_hooks17 and tls_hooks18 on BoringSSL build (apache#9455)
  Stabilize autest tls_hook18 (apache#9454)
  Fix parameter parser in ssl_hook_test plugin (apache#9453)
  Use SSL_get1_peer_certificate on OpenSSL3 build (apache#9460)
  records.yaml - Make some changes on the convert script. (apache#9466)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@randall randall randall approved these changes

@brbzull0 brbzull0 brbzull0 approved these changes

@masaori335 masaori335 Awaiting requested review from masaori335

Assignees

@bneradt bneradt

Labels

AuTest

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bneradt @randall @brbzull0