Upgrades master branch to use clang-format v15.0.7#9355
Merged
zwoop merged 1 commit intoapache:masterfrom Feb 2, 2023
Merged
Conversation
39977f9 to
bbcf771
Compare
Contributor
Author
|
[approve ci] |
maskit
reviewed
Feb 1, 2023
bneradt
reviewed
Feb 1, 2023
| for (int i = 0; i < numTok; i++) { | ||
| const char *current = pTok[i]; | ||
| int cnt = sz += strlen(current); | ||
| int cnt = sz += strlen(current); |
Contributor
There was a problem hiding this comment.
This is an interesting change. Most of the other changes add alignment with the previous = or whatever, this removes it. (This isn't a problem, just something that caught my eye.)
Contributor
Author
There was a problem hiding this comment.
Yeh, there are still imperfections :).
bneradt
approved these changes
Feb 1, 2023
Contributor
bneradt
left a comment
There was a problem hiding this comment.
I skimmed through about half of these files, up until github was autohiding the files because of the volume. I then ignored white space changes, which highlighted the changes that added or removed newlines.
I didn't see any changes I didn't like. I think these changes are an improvement and will make things more readable.
Thanks for keeping clang-format updated.
Contributor
|
And I do definitely like having the arm64 clang-format binaries. That makes running clang-format much quicker on my system. |
bryancall
approved these changes
Feb 1, 2023
moleksy
pushed a commit
to moleksy/trafficserver
that referenced
this pull request
Feb 8, 2023
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: (623 commits) records.config to records.yaml (apache#9264) Updates the release roadmap, adjusting for delays (apache#9360) Upgrades master branch to use clang-format v15.0.7 (apache#9355) Disable merging on GitHub (apache#9354) Clang-format 15.0.7 is finicky, and does not like these old school array inits (apache#9356) Enable merging for 10-Dev merge (apache#9353) Fix an error on SSL config reload (plus some cleanup). (apache#9334) Cleanup of legacy, makes newer clang-format crash right now (apache#9350) Update the roadmap / branch management doc page (apache#9340) Proxy Protocol out fixes (apache#9341) Memory leaks with storing configuration filenames (apache#9324) s3_auth autest: convert from gold file to file contains (apache#9337) Make 204 cacheable again (apache#9333) Add param to forward headers from the auth server to the origin (apache#9271) s3_auth: Fix assertion failure of TSActionCancel (apache#9329) Added http connect Autest with proxy verifier (apache#9315) s3_auth: Schedule reloading config event on TASK thread (apache#9328) Register ET_UDP thread type even if no UDP threads are requested (apache#9314) Don't send response body on status 204 No Content (apache#9330) Limit the serching range of static table by the first letter of header name (apache#9298) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the upgrade to v15.0.7, with its new features and fixes, this also adds binaries for aarch64 platforms for both Linux and macOS.