Skip to content

Updated warning message for adding duplicated remap entries#9306

Merged
maskit merged 2 commits intoapache:masterfrom
lzx404243:logging-duplicated-entry
Jan 13, 2023
Merged

Updated warning message for adding duplicated remap entries#9306
maskit merged 2 commits intoapache:masterfrom
lzx404243:logging-duplicated-entry

Conversation

@lzx404243
Copy link
Collaborator

@lzx404243 lzx404243 commented Jan 13, 2023

Current logs when the user specifies duplicated remap rules:

[Jan 10 23:34:36.437] traffic_server ERROR: Couldn't insert into trie!
[Jan 10 23:34:36.437] traffic_server WARNING: Could not insert new mapping
[Jan 10 23:34:36.437] traffic_server ERROR: [ReverseProxy] failed to add remap rule at /tmp/sb/duplicated_remap_entries/ts2/config/remap.config line 2: unable to add mapping rule to lookup table
[Jan 10 23:34:36.437] traffic_server WARNING: something failed during BuildTable() -- check your remap plugins!
[Jan 10 23:34:36.437] traffic_server EMERGENCY: remap.config failed to load

This PR changes the Could not insert new mapping to Could not insert new mapping: duplicated entry exists. to make it more explicit why the rule insertion fails.

bneradt
bneradt requested changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@bneradt bneradt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This will be helpful to people tripping on this.

@bneradt bneradt added this to the 10.0.0 milestone Jan 13, 2023
@maskit maskit merged commit ec3bcf3 into apache:master Jan 13, 2023
zwoop pushed a commit that referenced this pull request Jan 23, 2023
@lzx404243 @zwoop
Updated warning message for adding duplicated remap entries (#9306)
38a32bc 
* Updated log message

* Added a comment

(cherry picked from commit ec3bcf3)
@zwoop
Copy link
Contributor

zwoop commented Jan 23, 2023

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.1 Jan 23, 2023
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
@zwoop
Merge remote-tracking branch 'asf/9.2.x' into 9.2.x
fa4eba5 
* asf/9.2.x:
  Updated ChangeLog
  Fixed issue with SDK_API_HttpParentProxySet_Fail regression test (apache#9300)
  Updated warning message for adding duplicated remap entries (apache#9306)
  AuTests: update to Proxy Verifier v2.6.0 (apache#9307)
  glibc 2.37 will require additional explicit defines (apache#9325)
  ppc64 stack grows down (apache#9326)
  Fixes header level for remap inspector
  Updated ChangeLog
  Bump version to v9.2.0
  Finished the 9.2.x release notes
  Checkpoint so far, on page 10 out of 24
  Update rtd-theme to the latest version (apache#9316)
  Cleanup and prepare for 9.2.x sections
  Docs: Unpin Sphinx (apache#9311)
JosiahWI pushed a commit to JosiahWI/trafficserver that referenced this pull request Jul 19, 2023
Updated warning message for adding duplicated remap entries (apache#9306
535a96c 
) (apache#760)

* Updated log message

* Added a comment

(cherry picked from commit ec3bcf3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maskit maskit maskit approved these changes

@bneradt bneradt bneradt approved these changes

Assignees

@lzx404243 lzx404243

Labels

Configuration

Projects

None yet

Milestone

9.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@lzx404243 @zwoop @maskit @bneradt