Skip to content

Verbose SSL error logs #9225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serrislew merged 3 commits into from
Dec 7, 2022
Merged

Verbose SSL error logs #9225

serrislew merged 3 commits into from
Dec 7, 2022

Conversation

@serrislew
Copy link
Contributor

@serrislew serrislew commented Dec 1, 2022

Adding more verbose information to SSL error and debug logs

  • Explicitly stating (i.e. "[empty file]") for empty files to avoid confusion

Including #9222 with slight modifications

@serrislew serrislew force-pushed the update_ssl_cert_logs branch from 40ff7fa to dfbc301 Compare December 1, 2022 01:30
@serrislew serrislew force-pushed the update_ssl_cert_logs branch from dfbc301 to 9173491 Compare December 1, 2022 02:00
@maskit
Copy link
Member

maskit commented Dec 1, 2022

[approve ci fedora]

@maskit
Copy link
Member

maskit commented Dec 1, 2022 

../../../build/_aux/test-driver: line 112: 56759 Segmentation fault      (core dumped) "$@" >> "$log_file" 2>&1
FAIL: test_QUICLossDetector

I ran make check on my Fedora 36 VM (arm64) but the test passed successfully... I have no idea how this change could affect the test.

mlibbey
mlibbey reviewed Dec 1, 2022
View reviewed changes
@maskit
Copy link
Member

maskit commented Dec 1, 2022

Just rerunning the test on Fedora worked.

@vmamidi vmamidi mentioned this pull request Dec 1, 2022
Closed
@serrislew serrislew force-pushed the update_ssl_cert_logs branch from a8bc825 to 08eb980 Compare December 2, 2022 00:21
@vmamidi vmamidi added this to the 9.2.0 milestone Dec 2, 2022
@vmamidi vmamidi added the SSL label Dec 2, 2022
@zwoop zwoop modified the milestones: 9.2.0, 10.0.0 Dec 5, 2022
@serrislew serrislew merged commit 4a011db into apache:master Dec 7, 2022
zwoop pushed a commit that referenced this pull request Dec 8, 2022
@serrislew @zwoop
Verbose SSL error logs (#9225)
3000615 
* Verbose SSL error logs

* Update log wording

* Additional logging

Co-authored-by: Serris Lew <[email protected]>
(cherry picked from commit 4a011db)
@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Dec 8, 2022
@zwoop
Copy link
Contributor

zwoop commented Dec 8, 2022

Cherry-picked to v9.2.x

@serrislew serrislew mentioned this pull request Dec 9, 2022
Merged
@maskit maskit mentioned this pull request Jan 27, 2023
Merged
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
@zwoop
Merge remote-tracking branch 'asf/9.2.x' into 9.2.x
faa32d6 
* asf/9.2.x:
  Verbose SSL error logs (apache#9225)
  Use std::unique_ptr for X509 and BIO scoped heap objects. (apache#8954)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mlibbey mlibbey mlibbey left review comments

@ywkaras ywkaras ywkaras approved these changes

Assignees

@serrislew serrislew

Labels

SSL

Projects

None yet

Milestone

9.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@serrislew @maskit @zwoop @mlibbey @ywkaras @vmamidi