libswoc - replace string_view_util with libswoc version. #9203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
|
The builds are failing due to linking issues. Here's a link to the Ubuntu failure: |
aeb310f to
1ccd30a
Compare
Member
Author
|
Oh, I'm tracking the linking issues. The problem is all of that works perfectly locally. This is part of resolving the linking issues with #9193 . |
1ccd30a to
7d05fc4
Compare
7d05fc4 to
922c69d
Compare
Member
Author
|
Seriously? That fix worked? Gaaaaaaaaaaaaaaaaaaaaaaah! |
bneradt
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed both to remove redundancy and to avoid circular dependencies, as libswoc internals depend on the functions in the
string_viewutils.