Traffic Dump: fix YAML format for CONNECT requests#9139
Merged
bneradt merged 1 commit intoapache:masterfrom Oct 17, 2022
Merged
Traffic Dump: fix YAML format for CONNECT requests#9139bneradt merged 1 commit intoapache:masterfrom
bneradt merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
[approve ci autest] |
For CONNECT requests, Traffic Dump will not have a server-side protocol stack because we populate that on HTTP responses from the server. Since we simply establish a connection to the origin without exchanging an HTTP message, the stack is never populated. This resulted in malformed YAML because we started a sequence with a ','. This patch addresses this by not adding the ',' if the protocol description string is empty.
c41f25a to
74fef81
Compare
randall
approved these changes
Oct 17, 2022
zwoop
pushed a commit
that referenced
this pull request
Oct 17, 2022
For CONNECT requests, Traffic Dump will not have a server-side protocol stack because we populate that on HTTP responses from the server. Since we simply establish a connection to the origin without exchanging an HTTP message, the stack is never populated. This resulted in malformed YAML because we started a sequence with a ','. This patch addresses this by not adding the ',' if the protocol description string is empty. (cherry picked from commit 96acfe8)
Contributor
|
Cherry-picked to v9.2.x |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Updated ChangeLog Fail sni.yaml loading if related resources fail to load (apache#9132) fix contradicting documentation and say a bit about the resident size of a volume directory (apache#9133) AuTest automatic keylog file configuration (apache#9137) Traffic Dump: fix YAML format for CONNECT requests (apache#9139) Updated ChangeLog Remove intermediate buffer in PluginVC (apache#8698) Fix HTTP/2 session receive window handling for small sizes (apache#9117) (apache#9122) 9.2: Fix s3_auth_config test output check (apache#9123) Conflicts: CHANGELOG-9.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For CONNECT requests, Traffic Dump will not have a server-side protocol stack because we populate that on response from the server. Since the connection is left open for tunneling, it never gets populated. This resulted in mal-formed YAML because we had an empty string followed by a ','.