Merged
Conversation
masaori335
approved these changes
Aug 17, 2022
Contributor
masaori335
left a comment
There was a problem hiding this comment.
Looks reasonable.
The CacheHostTableConfig is allocated on scheduling the event and nobody owns the pointer.
trafficserver/iocore/cache/CacheHosting.cc
Lines 228 to 235 in 2e31ef8
Contributor
|
Cherry-picked to v9.2.x |
zwoop
pushed a commit
that referenced
this pull request
Aug 23, 2022
(cherry picked from commit ef30532)
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Aug 23, 2022
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Updated ChangeLog utilize proxy.config.hostdb.host_file.interval config variable (apache#9039) Remove plugin parent_select unused symbols (apache#9023) Require use of 'override' keyword when valid. (apache#8737) Fix compile error on macOS (apache#9047) Validate that content length header matches object size on cache read (apache#8976) Fix reload memory leak (apache#9041) Update prepare_proxy_verifier.sh to work in non-git directories (apache#9048) Change linux/fs include to build with glibc 2.36 (apache#9027) ts::shared_mutex - Fix lock counting for debug (apache#9040)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak when reloading hosting.config.
I manually tested and ran, modified hosting.config and reloaded. Appears to work, requests and things continue to work, debug prints in the constructor and destructor show a new
CacheHostTableConfigbeing allocated on reload, and the old one being deleted once and only once.Recommend backporting to All The Things. Appears to have been a bug forever.