[8.1.x] Backport HTTP Validations#9015
Merged
ezelkow1 merged 5 commits intoapache:8.1.xfrom Aug 9, 2022
Merged
Conversation
00f1215 to
5b4474f
Compare
(cherry picked from commit eaef5e8) Conflicts: proxy/http2/HTTP2.cc
Strictly following RFC 3986 Section 3.1 ``` scheme = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." ) ``` (cherry picked from commit c56f872) Conflicts: proxy/hdrs/unit_tests/test_URL.cc proxy/http2/HTTP2.cc To compile unit tests, Makefile.am is changed too.
(cherry picked from commit 2f363d9) Conflicts: proxy/hdrs/Makefile.am proxy/hdrs/unit_tests/test_Hdrs.cc tests/gold_tests/headers/good_request_after_bad.test.py tests/gold_tests/logging/gold/field-json-test.gold tests/gold_tests/logging/log-field-json.test.py Add to run unit test: proxy/hdrs/unit_tests/unit_test_main.cc
…NUATION frame (apache#9012) * Add content length mismatch check on handling HEADERS frame and CONTINUATION frame * Correct error class of HTTP/2 malformed requests (cherry picked from commit e921228)
(cherry picked from commit 1f3e111)
5b4474f to
81f7987
Compare
ezelkow1
approved these changes
Aug 9, 2022
Member
ezelkow1
left a comment
There was a problem hiding this comment.
Compared to existing PRs this pulls in, looks like it covers everything to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #9009, #9010, #9011, #9012, and #9013 to the 8.1.x branch.