test_jsonrpcserver: do not remove files from /tmp#8794
Merged
bneradt merged 1 commit intoapache:10-Devfrom Apr 14, 2022
Merged
Conversation
Some tests create a so-called sandbox directory, use it for the files the object under test creates, then remove that temporary sandbox directory. To do this they use getTemporaryDir(). The test_jsonrpcserver test attempted to do the same thing, but since that function wasn't readily available, it used a similarly sounding fs::temp_directory_path(). That function, however, just references /tmp. As a result, test_jsonrpcserver would store files in /tmp then remove /tmp instead of a test-specific temporary directory. This is a problem since it would remove other processes' temporary files stored in /tmp along with its own test files. This patch fixes this by creating getTemporaryDir() for test_jsonrpcserver and calling that instead. Fixes apache#8792
ezelkow1
approved these changes
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests create a so-called sandbox directory, use it for the files
the object under test creates, then remove that temporary sandbox
directory. To do this they use getTemporaryDir(). The test_jsonrpcserver
test attempted to do the same thing, but since that function wasn't
readily available, it used a similarly sounding
fs::temp_directory_path(). That function, however, just references /tmp.
As a result, test_jsonrpcserver would store files in /tmp then remove
/tmp instead of a test-specific temporary directory. This is a problem
since it would remove other processes' temporary files stored in /tmp
along with its own test files. This patch fixes this by creating
getTemporaryDir() for test_jsonrpcserver and calling that instead.
Fixes #8792