Add autest to cover updates to cache with alternates #8779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
When digging into this issue, it appears to stem from setting a CacheVC instance variable called Later in the transaction, when a response with a Because we are already reading the |
bneradt
previously approved these changes
Apr 5, 2022
Contributor
bneradt
left a comment
There was a problem hiding this comment.
The test looks good. Thanks for adding a regression test for this.
tests/gold_tests/cache/replay/alternate-caching-update-size.yaml
Outdated
Show resolved
Hide resolved
Contributor
|
Looks like this is causing the alternate-caching Au test to fail. |
Contributor
Author
|
Yes, this PR is just an autest that demonstrates the bug with alternate cache updates so that people could reason about it. A fix is forthcoming and then this autest will pass. |
bneradt
requested changes
Apr 20, 2022
Contributor
|
Looks good. |
Contributor
|
Merging this PR on behalf of @cmcfarlen due to the approval from @bneradt and my own knowledge of how this works. |
Contributor
|
Cherry-picked to v9.2.x |
zwoop
pushed a commit
that referenced
this pull request
May 16, 2022
* Add autest to cover updates to cache with alternates * remove trailing line(autopep8) * add comments describing the requests * reduce delay and max-age on test * set cache object size to zero when incoming content length is zero * add demystifying comment Co-authored-by: Chris McFarlen <cmcfarlen@apple.com> (cherry picked from commit 4c5b182)
Contributor
|
We faced another symptom made by this bug. If the half-updated object is big enough (> 1GB) and it's on the RAM Cache, you might see the below crash made by a huge loop on cache read. ( the number of call stack is over 8000 ) |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Jul 26, 2022
…pache#356) * Add autest to cover updates to cache with alternates * remove trailing line(autopep8) * add comments describing the requests * reduce delay and max-age on test * set cache object size to zero when incoming content length is zero * add demystifying comment Co-authored-by: Chris McFarlen <cmcfarlen@apple.com> (cherry picked from commit 4c5b182) Co-authored-by: Chris McFarlen <chris@mcfarlen.us>
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Updated ChangeLog Fix parent_select optional scheme (apache#8831) Add `#pragma once` for PendingAction.h (apache#8846) Promote class PendingAction from HttpSM.h for use in other classes. (apache#8423) Fixes leak in SNIAction name globbing (apache#8827) Handle opentelemetry-cpp v1.3.0 upgrade for otel_tracer plugin (apache#8834) Fix overflow conditions in prefetch plugin (apache#8660) Remove incorrect comment from base64 functions (apache#8835) Add autest to cover updates to cache with alternates (apache#8779)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This autest demonstrates an issue with cache alternates and updating from a response with a content-length to one with content-length 0.
When an alternate is replaced, and previously had a content-length, there is a bug where then old content is preserved and only this headers are changed (and the new 0-length content is not "written"). When this half-updated asset is served from cache, the content length is mismatched, delivered via chunked encoding and the old contents are shipped to the client.