Skip to content

Commenting TSHttpTxnCacheLookupStatusGet need_to_revalidate #8621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bneradt merged 1 commit into from
Jan 19, 2022
Merged

Commenting TSHttpTxnCacheLookupStatusGet need_to_revalidate #8621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/traffic_server/InkAPI.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5430,6 +5430,15 @@ TSHttpTxnCacheLookupStatusGet(TSHttpTxn txnp, int *lookup_status)
case HttpTransact::CACHE_LOOKUP_HIT_WARNING:
case HttpTransact::CACHE_LOOKUP_HIT_FRESH:
if (HttpTransact::need_to_revalidate(&sm->t_state)) {
// Note that in this case the object was determined to be fresh but there
// was a problem with the cached object for this request per
// need_to_revalidate(). need_to_revalidate() checks for issues such as
// the need to authenticate with the origin or the incoming request
// method doesn't equal the method of the request for the cached
// response. Issues like this are more accurately described as a MISS
// rather than STALE because they are not due to freshness (timing)
// issues but rather to characteristics that make the cached object
// inappropriate as a response to this request.
*lookup_status = TS_CACHE_LOOKUP_MISS;
} else {
*lookup_status = TS_CACHE_LOOKUP_HIT_FRESH;
Expand Down