Adds autest to test error cases loading ssl_multicert.config#8532
Merged
randall merged 1 commit intoapache:masterfrom Nov 23, 2021
Merged
Adds autest to test error cases loading ssl_multicert.config#8532randall merged 1 commit intoapache:masterfrom
randall merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
[approve ci] |
mlibbey
reviewed
Nov 20, 2021
| tr.Processes.Default.StartBefore(server) | ||
| tr.StillRunningAfter = ts | ||
| tr.StillRunningAfter = server | ||
| tr.Processes.Default.Command = f"curl -q -s -v -k --resolve '{sni_domain}:{ts.Variables.ssl_port}:127.0.0.1' https://{sni_domain}:{ts.Variables.ssl_port}" |
Contributor
There was a problem hiding this comment.
What would you think about adding a comment here about why -k is needed for our future selves. I presume its something about a self signed cert / chain doesn't validate?
Contributor
Author
There was a problem hiding this comment.
Almost all the tests that use curl to do https use -k or --insecure and the ones that don't, specify --cacert.
It's all copy paste!
bneradt
requested changes
Nov 22, 2021
Contributor
bneradt
left a comment
There was a problem hiding this comment.
I have a few minor comments, but overall this looks good. Thanks for adding coverage for this!
| tr2.Processes.Default.Env = ts.Env | ||
| tr2.Processes.Default.ReturnCode = 0 | ||
|
|
||
| ts.Disk.diags_log.Content = Testers.ContainsExpression('ERROR: ', 'ERROR') |
Contributor
There was a problem hiding this comment.
Maybe this should be added as a TestRun (tr2reload) file like you did for the multicert_config above? I think that way it will check during the execution of the reload and not globally after all the tests complete.
46f6cbf to
a59067e
Compare
With this test in place, we might've caught apache#8515 and apache#8256 earlier
a59067e to
3bdc3ea
Compare
zwoop
pushed a commit
that referenced
this pull request
Dec 1, 2021
Contributor
|
Cherry-picked to v9.2.x |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Mar 17, 2022
* asf/9.2.x: Updated ChangeLog remove unused function (apache#8525) Adds autest to test error cases loading ssl_multicert.config (apache#8532) Set an appropriate callback function for OpenSSL3 (apache#8524) Eliminate unused code in LogObject. (apache#8541) Enable conf_remap_float test and remove special case for local config file (apache#8540) ssl_verify_test: clang-analyzer fix to account for nul sni_name (apache#8462) Updated ChangeLog
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Jul 26, 2022
…8532) With this test in place, we might've caught apache#8515 and apache#8256 earlier (cherry picked from commit 7bc025c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this test in place, we might've caught #8515 and #8256 earlier