Skip to content

Conversation

@ezelkow1
Copy link
Member

Cherry-picks of
9b47aa6: proxy.config.http.connect_attempts_timeout tracks TTBF instead of connect (Susan Hinrichs)
9a8998e: HttpSM: add case check for VC_EVENT_INACTIVE_TIMEOUT, VC_EVENT_READ_READY, VC_EVENT_READ_COMPLETE (Brian Olsen)

We have run with these in production for many many months now on 8.1.x and they also seem to fix #7710

shinrich and others added 2 commits April 19, 2021 08:57
@ezelkow1 ezelkow1 added the Backport Marked for backport for an LTS patch release label Apr 19, 2021
@ezelkow1 ezelkow1 added this to the 8.1.2 milestone Apr 19, 2021
@ezelkow1 ezelkow1 self-assigned this Apr 19, 2021
jrushford
jrushford previously approved these changes Apr 19, 2021
Copy link
Contributor

@jrushford jrushford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this change in trafficserver 8.1.1 on CentOS 7.6 and it fixes #7710

@jrushford jrushford dismissed their stale review April 19, 2021 16:11

FreeBSD CI failure

@zwoop zwoop requested a review from vmamidi April 19, 2021 21:31
{
bool retval = sslHandshakeBeginTime == 0;
if (retval) {
sslHandshakeBeginTime = Thread::get_hrtime();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems odd that sslHandshakeBeginTime does not exist on the master branch.

wkaras ~/REPOS/TS3
M$ fgrep sslHandshakeBeginTime $(findsrc)
wkaras ~/REPOS/TS3
M$ git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	.srcfmt

nothing added to commit but untracked files present (use "git add" to track)
wkaras ~/REPOS/TS3
M$

@ezelkow1
Copy link
Member Author

[approve ci freebsd]

@ezelkow1 ezelkow1 merged commit 4478392 into apache:8.1.x Apr 30, 2021
@ezelkow1 ezelkow1 deleted the BP-timeout-fixes branch June 22, 2021 18:23
ezelkow1 added a commit that referenced this pull request Jun 22, 2021
ezelkow1 added a commit that referenced this pull request Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport Marked for backport for an LTS patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants