Add an assert to check do_io_close is called#7595
Closed
maskit wants to merge 1 commit intoapache:masterfrom
Closed
Add an assert to check do_io_close is called#7595maskit wants to merge 1 commit intoapache:masterfrom
maskit wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
[approve ci autest] |
1 similar comment
Contributor
|
[approve ci autest] |
Member
|
[approve ci autest] |
Member
Author
|
Autest won't pass until #7594 gets merged. |
Member
Author
|
[approve ci autest] |
Member
Author
|
Gave up for now because this would require quite a few changes. It would be better to wait for H2 to Origin at minimum.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we should always call
do_io_closeifdo_io_read/writeis called.This should not be merged until #7594 is merged.