autopep8: avoid running on non-tracked files.#7190
Closed
bneradt wants to merge 1 commit intoapache:9.0.xfrom
Closed
autopep8: avoid running on non-tracked files.#7190bneradt wants to merge 1 commit intoapache:9.0.xfrom
bneradt wants to merge 1 commit intoapache:9.0.xfrom
Conversation
It was found that if someone has non-commited Python files, such as can happen if they have a virtual environment in their source tree, autopep8 will inspect those as well. This is slow and probably not desired by the user. This patch only runs autopep8 on files tracked by git. It will also enable autopep8 to check .test.ext extensions, thus the updates to those files. It also has autopep8 run silently so it doesn't produce as much noise. (cherry picked from commit a815016)
bryancall
approved these changes
Sep 14, 2020
Contributor
|
This cherry-picks cleanly, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry pick to 9.0.x of the following PR:
#7186
It was found that if someone has non-commited Python files, such as can
happen if they have a virtual environment in their source tree, autopep8
will inspect those as well. This is slow and probably not desired by the
user.
This patch only runs autopep8 on files tracked by git. It will also
enable autopep8 to check .test.ext extensions, thus the updates to those
files.
It also has autopep8 run silently so it doesn't produce as much noise.
(cherry picked from commit a815016)