AuTest: Properly handle experimental plugins. (#6971)#7169
Merged
zwoop merged 1 commit intoapache:9.0.xfrom Sep 6, 2020
Merged
AuTest: Properly handle experimental plugins. (#6971)#7169zwoop merged 1 commit intoapache:9.0.xfrom
zwoop merged 1 commit intoapache:9.0.xfrom
Conversation
Susan observed a couple issues with certain configurations now that we are building AuTest plugins via the Automake system: 1. Without ` --enable-experimental-plugins` and `--enable-example-plugins`: A couple tests used to build some experimental plugins by themselves with a copy-and-pasted version of the experimental plugin in the tools directory. This way the test would run regardless of whether the user configured their make with --experimental-plugins. That clearly won't work now that the standard installed plugins are built with Automake. To address this, I'm adding a skip check associated with these plugins. 2. Susan also executed `make install` via sudo because she was installing in the root filesystem and needed root privilege. The PreparePlugin script copies down the plugins into the sandbox directory. For all the test plugins this is fine, but for the standard ATS plugins, this attempt to copy down upon a root sym link would fail with an EPERM. I'm addressing this by providing both a PrepareTestPlugin and PrepareInstalledPlugin in which the latter does not copy down the plugin `.so` file because it is already installed via `make install`. (cherry picked from commit 7ef20c6)
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Jan 26, 2021
* asf/9.0.x: leaks in logs (apache#7172) AuTest: Reuse venv if it exists already (apache#7178) Emits log when OCSP fails to connect to server (apache#7183) Do not lose original inactivity timeout on disable (apache#7134) Fix apache#7164 Chaning Warning to Debug and creating a stat for inserting duplicates to pending dns (apache#7166) Removes references to non-existent function handle_conditional_headers (apache#7162) AuTest: Properly handle experimental plugins. (apache#6971) (apache#7169) Updated ChangeLog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick to 9.0.x with manually resolved merge conflicts for:
#6971
Susan observed a couple issues with certain configurations now that
we are building AuTest plugins via the Automake system:
Without
--enable-experimental-pluginsand--enable-example-plugins: A couple tests used to build someexperimental plugins by themselves with a copy-and-pasted version of the
experimental plugin in the tools directory. This way the test would run
regardless of whether the user configured their make with
--experimental-plugins. That clearly won't work now that the standard
installed plugins are built with Automake. To address this, I'm adding a
skip check associated with these plugins.
Susan also executed
make installvia sudo because she wasinstalling in the root filesystem and needed root privilege. The
PreparePlugin script copies down the plugins into the sandbox directory.
For all the test plugins this is fine, but for the standard ATS plugins,
this attempt to copy down upon a root sym link would fail with an EPERM.
I'm addressing this by providing both a PrepareTestPlugin and
PrepareInstalledPlugin in which the latter does not copy down the plugin
.sofile because it is already installed viamake install.(cherry picked from commit 7ef20c6)