-
Notifications
You must be signed in to change notification settings - Fork 852
Move to blocklists and allowlists #6913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The words blocklist and allowlist are equally descriptive as their racially charged alternatives and gaining industry-wide acceptance. Still need to go through the Japanese docs to do the same.
Do we want to completely remove the words from the repo or is it ok if those words and the translations will not be on actual docs? |
|
Chatting with maskit and masaori335 about the Japanese translations -- with the translation process, sounds like they are better for a distinct PR. |
|
If you're renaming plugins, you'll also have to update the appropriate Makefiles. Also the plugins contents contain blacklist. |
|
I thought this was a doc only PR so I created #6918 but closed it when I saw you had source changes as well. There's also the sni_whitelist plugin that needs to be renamed |
|
I merged #6918, you'll need to rebase your change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, assuming the git/build errs get fixed :)
|
Closing this since @randall is going to take this, and make a new, cleaned up PR. |
|
This is now #7034 |
The words blocklist and allowlist are equally descriptive as their racially
charged alternatives and gaining industry-wide acceptance.
Still need to go through the Japanese docs to do the same.