Skip to content

Conversation

@mlibbey
Copy link
Contributor

@mlibbey mlibbey commented Jun 17, 2020

The words blocklist and allowlist are equally descriptive as their racially
charged alternatives and gaining industry-wide acceptance.

Still need to go through the Japanese docs to do the same.

The words blocklist and allowlist are equally descriptive as their racially
charged alternatives and gaining industry-wide acceptance.

Still need to go through the Japanese docs to do the same.
@maskit
Copy link
Member

maskit commented Jun 17, 2020

Still need to go through the Japanese docs to do the same.

Do we want to completely remove the words from the repo or is it ok if those words and the translations will not be on actual docs?

@mlibbey
Copy link
Contributor Author

mlibbey commented Jun 18, 2020

Chatting with maskit and masaori335 about the Japanese translations -- with the translation process, sounds like they are better for a distinct PR.

@randall
Copy link
Contributor

randall commented Jun 18, 2020

If you're renaming plugins, you'll also have to update the appropriate Makefiles. Also the plugins contents contain blacklist.

@randall
Copy link
Contributor

randall commented Jun 18, 2020

I thought this was a doc only PR so I created #6918 but closed it when I saw you had source changes as well.

There's also the sni_whitelist plugin that needs to be renamed

@randall
Copy link
Contributor

randall commented Jun 22, 2020

I merged #6918, you'll need to rebase your change.

Copy link
Member

@ezelkow1 ezelkow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, assuming the git/build errs get fixed :)

@zwoop zwoop removed this from the 10.0.0 milestone Jul 23, 2020
@zwoop
Copy link
Contributor

zwoop commented Jul 23, 2020

Closing this since @randall is going to take this, and make a new, cleaned up PR.

@randall
Copy link
Contributor

randall commented Jul 23, 2020

This is now #7034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants