Use Proxy-Connection iff parent_is_proxy=true #6780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change a parent proxy configured as parent_is_proxy=false would get Proxy-Connection: keep-alive|close instead of Connection: keep-alive|close
Contributor
|
@jvgutierrez This change makes sense to me but I'd like to get an opinion from @vmamidi |
jrushford
approved these changes
May 14, 2020
Contributor
jrushford
left a comment
There was a problem hiding this comment.
@jvgutierrez this looks good to me.
vmamidi
approved these changes
May 14, 2020
wmfgerrit
pushed a commit
to wikimedia/operations-puppet
that referenced
this pull request
May 19, 2020
Handling Keep-Alive and websocket headers configuration via tls.lua seems to be a 1:1 mapping between our old nginx configuration and ATS. ATS provides proper configuration settings and remap rules for both scenarios making manual header handling via tls.lua redundant and unnecessary. Additionally, benefit from apache/trafficserver#6780 and stop removing Proxy-Connection unconditionally on every request. This PR has been backported in trafficserver 8.0.7-1wm10. Change-Id: I343d2877ea89df70d66d4f593278127c4a177d2c
Contributor
|
Cherry-picked to v9.0.x branch, but we'll also add #7483 which fixes this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change a parent proxy configured as parent_is_proxy=false would get
Proxy-Connection: keep-alive|closeinstead ofConnection: keep-alive|close