Skip to content

TS-4483: NetAccept & SSLNetAccept Optimize, replace getEtype() with member etype.#665

Closed
oknet wants to merge 1 commit intoapache:masterfrom
oknet:netaccept
Closed

TS-4483: NetAccept & SSLNetAccept Optimize, replace getEtype() with member etype.#665
oknet wants to merge 1 commit intoapache:masterfrom
oknet:netaccept

Conversation

@oknet
Copy link
Member

@oknet oknet commented May 25, 2016

No description provided.

@zwoop
Copy link
Contributor

zwoop commented May 25, 2016

What's the Jira # for this?

@oknet
Copy link
Member Author

oknet commented May 25, 2016

Sorry, forget to create it, please link to TS-4483.

@zwoop
Copy link
Contributor

zwoop commented May 25, 2016

Cool. Can you rename Subject line for this PR to include the Jira # please?

@shinrich
Copy link
Member

I thought we were getting rid of the SSL threads (and thus ET_SSL). If so, we could probably do some more simplification here.

@oknet oknet changed the title NetAccept & SSLNetAccept Optimize, replace getEtype() with member etype. TS-4483: NetAccept & SSLNetAccept Optimize, replace getEtype() with member etype. May 26, 2016
@oknet
Copy link
Member Author

oknet commented May 26, 2016

@shinrich ET_SSL is still here. SSLNetAccept::etype is set to ET_SSL by sslNetProcessor::upgradeEtype().

@shinrich
Copy link
Member

Yes, I know it is still there. Just bringing up the broader issue since you are working in that area anyway. @zwoop and @SolidWallOfCode am I remembering correctly that ultimately we are looking at getting rid of the SSL threads?

@zwoop
Copy link
Contributor

zwoop commented May 26, 2016

Ya, I believe the idea was to eliminate ET_SSL for 7.0.0. See https://issues.apache.org/jira/browse/TS-3046.

@zwoop zwoop added the Network label May 31, 2016
@zwoop zwoop added this to the 7.0.0 milestone May 31, 2016
@jpeach
Copy link
Contributor

jpeach commented Jun 23, 2016

This looks very reasonable to me. @oknet can you please rebase onto master?

@oknet
Copy link
Member Author

oknet commented Jun 23, 2016

@jpeach create a new PR#734 base on master.

@oknet oknet closed this Jun 23, 2016
@zwoop zwoop modified the milestone: 7.0.0 May 4, 2017
JosiahWI pushed a commit to JosiahWI/trafficserver that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants