TS-4442: Fix code coverage. #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@bryancall Wasn't there a reason why we changed to _exit() again? |
Contributor
|
[approve ci] |
Contributor
|
Same here, did you really intend for these branches to get pushed into the main repo? |
Fix the --enable-coverage option to correctly pass the right compilation flags. Make a special case for LuaJIT, since we don't really want to enable coverage for third-party code.
We should not be using _exit() unless the circumstances are really exceptional. Replace all uses of _exit with exit(), except for signal handlers and exec failures. This is necessary for emitting code coverage data.
shinrich
added a commit
to shinrich/trafficserver
that referenced
this pull request
Jan 9, 2018
Build: Fix build problems on RHEL 6 for traffic_top.
ywkaras
pushed a commit
to ywkaras/trafficserver
that referenced
this pull request
Jul 7, 2022
Revert "body factory does not respect runroot (apache#8388)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the code coverage configuration and removes calls to
_exitthat prevent coverage data being emitted. Note that we assume the fix for TS-4441 and replace a couple of manual exits withFatal.