Enhance Connection Collapse in ATS core#6053
Merged
sudheerv merged 1 commit intoapache:masterfrom Oct 23, 2019
Merged
Conversation
Add an option to support cache open read retry on a write lock failure. With this option, as long as read-while-writer is set up following the guidelines in the docs, there should be no need for any plugins to augment the core. Eventual plan is to deprecate collapsed_forwarding plugin with this new support. For more context on this, see https://cwiki.apache.org/confluence/display/TS/Presentations+-+2019?preview=/112821251/132320653/Collapsed%20Forwarding%20.pdf
Member
|
link to #6028 |
Contributor
Author
|
Thanks @scw00 for the thorough review! |
ezelkow1
approved these changes
Oct 23, 2019
Member
ezelkow1
left a comment
There was a problem hiding this comment.
Did some basic testing with fake duplicated requests and appears to work so far for me
Contributor
|
Cherry-picked to v9.0.x branch. |
Contributor
|
@sudheerv Should we remove the connection collapsing plugin from v10.0.0 ? |
Contributor
|
Also, if we want this for an 8.x release, we'll need a PR for it. |
Contributor
Author
Yeah, Agree. Will send out an email to dev@ first though and cleanup the old configs and plugin after that. |
Contributor
Author
Sure, will create a PR. Here it is - |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option to support cache open read retry on a write lock
failure. With this option, as long as read-while-writer is set
up following the guidelines in the docs, there should be no need
for any plugins to augment the core. Eventual plan is to deprecate
collapsed_forwarding plugin with this new support.
For more context on this, see
https://cwiki.apache.org/confluence/display/TS/Presentations+-+2019?preview=/112821251/132320653/Collapsed%20Forwarding%20.pdf
Note: PR #7586 fixes an issue that appears to have been introduced by this PR.