Skip to content

Cleanup: Replace TS_INLINE with inline specifier #5940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
masaori335 wants to merge 1 commit into from
Closed

Cleanup: Replace TS_INLINE with inline specifier #5940

masaori335 wants to merge 1 commit into from

Conversation

@masaori335
Copy link
Contributor

@masaori335 masaori335 commented Sep 17, 2019

  • Remove Inline.cc
  • Remove TS_INLINE from UnixNetVConnection.cc
  • Ran below command to replace TS_INLINE
LC_ALL=C find . -name "*.h" -exec sed -i '' s/TS_INLINE/inline/g {} +

@masaori335 masaori335 added this to the 10.0.0 milestone Sep 17, 2019
@masaori335 masaori335 self-assigned this Sep 17, 2019
@SolidWallOfCode
Copy link
Member

SolidWallOfCode commented Sep 18, 2019

Looks like you're missing a #include in the IOBuffer unit tests.

@masaori335
Copy link
Contributor Author

masaori335 commented Sep 19, 2019 •
edited
Loading

Right. It looks like removing Include.cc made the requirement.
I made similar changes for below unit tests.

        modified:   iocore/eventsystem/unit_tests/test_IOBuffer.cc
        modified:   iocore/eventsystem/unit_tests/test_MIOBufferWriter.cc
        modified:   iocore/net/test_I_UDPNet.cc

Also, it requires to filp order of librecords_p.a and libinkevent.a in *_LDADD.

@masaori335
Cleanup: Replace TS_INLINE with inline specifier
14cf6d8 
- Remove Inline.cc files
- Remove TS_INLINE from source file
  - iocore/net/UnixNetVConnection.cc
- Ran below command to replace TS_INLINE
  ```
  LC_ALL=C find . -name "*.h" -exec sed -i '' s/TS_INLINE/inline/g {} +
  ```
- Include missing header files in unit tests because of removing Inline.cc files
  - iocore/eventsystem/unit_tests/test_IOBuffer.cc
  - iocore/eventsystem/unit_tests/test_MIOBufferWriter.cc
  - iocore/net/test_I_UDPNet.cc
- Flip order of librecords_p.a and libinkevent.a in *_LDADD
@masaori335 masaori335 added the WIP label Sep 19, 2019
@masaori335
Copy link
Contributor Author

masaori335 commented Sep 19, 2019 •
edited
Loading

Mark WIP until complete PR builders & test with enabling QUIC on Linux.

@masaori335
Copy link
Contributor Author

masaori335 commented Oct 3, 2019

I realized the trick of TS_INLINE. If the header file is included by Inline.cc, the inline specifier will be removed by defining TS_INLINE as nothing. This is why some builds are failed.

trafficserver/iocore/eventsystem/Inline.cc

Line 29 in 29b1dc9

#define TS_INLINE

@bryancall
Copy link
Contributor

bryancall commented Oct 17, 2019

[approve ci]

@masaori335
Copy link
Contributor Author

masaori335 commented Apr 12, 2020

I'll rework if I get some ideas.

@masaori335 masaori335 closed this Apr 12, 2020
@zwoop zwoop removed this from the 10.0.0 milestone May 14, 2020
@masaori335 masaori335 mentioned this pull request Feb 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@masaori335 masaori335

Labels

Cleanup Core WIP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@masaori335 @SolidWallOfCode @bryancall @zwoop